Skip to content

Commit eb2b1b4

Browse files
committed
tests(derive_code_mappings):
In #42712 it was reported that are usage of `called_with` is incorrect. Unfortunately, using `assert_called_with` does not work because comparing `NodeData` would require extra work to make the comparison of two objects work well.
1 parent 9e5e00b commit eb2b1b4

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

tests/sentry/tasks/test_post_process.py

+5-13
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
from sentry.models.activity import ActivityIntegration
3030
from sentry.ownership.grammar import Matcher, Owner, Rule, dump_schema
3131
from sentry.rules import init_registry
32+
from sentry.tasks.derive_code_mappings import SUPPORTED_LANGUAGES
3233
from sentry.tasks.merge import merge_groups
3334
from sentry.tasks.post_process import post_process_group, process_event
3435
from sentry.testutils import SnubaTestCase, TestCase
@@ -173,19 +174,10 @@ def test_derive_invalid_platform(self, mock_derive_code_mappings):
173174
assert mock_derive_code_mappings.delay.call_count == 0
174175

175176
@patch("sentry.tasks.derive_code_mappings.derive_code_mappings")
176-
def test_derive_python(self, mock_derive_code_mappings):
177-
data = {"platform": "python"}
178-
self._call_post_process_group(data)
179-
assert mock_derive_code_mappings.delay.call_count == 1
180-
assert mock_derive_code_mappings.delay.called_with(self.project.id, data, False)
181-
182-
@patch("sentry.tasks.derive_code_mappings.derive_code_mappings")
183-
def test_derive_js(self, mock_derive_code_mappings):
184-
data = {"platform": "javascript"}
185-
self._call_post_process_group(data)
186-
assert mock_derive_code_mappings.delay.call_count == 1
187-
# Because we only run on dry run mode even if the official flag is set
188-
assert mock_derive_code_mappings.delay.called_with(self.project.id, data, True)
177+
def test_derive_supported_languages(self, mock_derive_code_mappings):
178+
for platform in SUPPORTED_LANGUAGES:
179+
self._call_post_process_group({"platform": platform})
180+
assert mock_derive_code_mappings.delay.call_count == 1
189181

190182

191183
class RuleProcessorTestMixin(BasePostProgressGroupMixin):

0 commit comments

Comments
 (0)