Skip to content

Commit ea2a1d0

Browse files
committed
Filter elt.parentNode Google Search app bug
See: getsentry/sentry-javascript#756 cc @dcramer @LewisJEllis
1 parent 1a841cb commit ea2a1d0

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

src/sentry/filters/browser_extensions.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,11 @@
2626
'EBCallBackMessageReceived',
2727
# See https://groups.google.com/a/chromium.org/forum/#!topic/chromium-discuss/7VU0_VvC7mE
2828
'_gCrWeb',
29-
# See http://toolbar.conduit.com/Developer/HtmlAndGadget/Methods/JSInjection.aspx
30-
'conduitPage'
29+
# See http://toolbar.conduit.com/Debveloper/HtmlAndGadget/Methods/JSInjection.aspx
30+
'conduitPage',
31+
# Google Search app (iOS)
32+
# See: https://github.com/getsentry/raven-js/issues/756
33+
'null is not an object (evaluating \'elt.parentNode\')'
3134
))), re.I)
3235

3336
EXTENSION_EXC_SOURCES = re.compile('|'.join((

tests/sentry/filters/test_browser_extensions.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,10 @@ def test_filters_conduit_toolbar(self):
4343
data = self.get_mock_data(exc_value='what does conduitPage even do')
4444
assert self.apply_filter(data)
4545

46+
def test_filters_google_search_app_ios(self):
47+
data = self.get_mock_data(exc_value='null is not an object (evaluating \'elt.parentNode\')')
48+
assert self.apply_filter(data)
49+
4650
def test_filters_chrome_extensions(self):
4751
data = self.get_mock_data(exc_source='chrome://my-extension/or/something')
4852
assert self.apply_filter(data)

0 commit comments

Comments
 (0)