From aca1f4f1eb335e38296b0a491e37ae1f0b4ed29b Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Fri, 17 Feb 2023 11:39:38 +0100 Subject: [PATCH] ci: Ensure we can actually run size-limit for release branches Based on https://github.com/getsentry/size-limit-action/pull/8, this ensures we can actually run size-limit on release branches, which currently fails. --- .github/workflows/build.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 6a9f6372afb9..45aa5f4ec595 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -298,11 +298,14 @@ jobs: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} - name: Check bundle sizes - uses: getsentry/size-limit-action@main-skip-step + uses: getsentry/size-limit-action@runForBranch with: github_token: ${{ secrets.GITHUB_TOKEN }} skip_step: build main_branch: develop + # When on release branch, we want to always run + # Else, we fall back to the default handling of the action + run_for_branch: ${{ (needs.job_get_metadata.outputs.is_release == 'true' && 'true') || '' }} job_lint: name: Lint