From 0e8cd8f91f1f80373be156d43941f01c83f71ee8 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Mon, 17 Oct 2022 13:29:09 -0700 Subject: [PATCH 1/2] add `RequestData` to default node integrations --- packages/node/src/sdk.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/node/src/sdk.ts b/packages/node/src/sdk.ts index d31fd5e45233..d02245f19132 100644 --- a/packages/node/src/sdk.ts +++ b/packages/node/src/sdk.ts @@ -27,6 +27,7 @@ import { Modules, OnUncaughtException, OnUnhandledRejection, + RequestData, } from './integrations'; import { getModule } from './module'; import { makeNodeTransport } from './transports'; @@ -46,6 +47,7 @@ export const defaultIntegrations = [ new ContextLines(), new Context(), new Modules(), + new RequestData(), // Misc new LinkedErrors(), ]; From 9afe86578c900820ebbffa5f9778ac62b9b9f0f1 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Mon, 17 Oct 2022 13:34:23 -0700 Subject: [PATCH 2/2] remove `RequestData` integration from nextjs server-side default integrations --- packages/nextjs/src/index.server.ts | 3 --- packages/nextjs/test/index.server.test.ts | 2 -- 2 files changed, 5 deletions(-) diff --git a/packages/nextjs/src/index.server.ts b/packages/nextjs/src/index.server.ts index 98037d2c777a..285c6eb1599e 100644 --- a/packages/nextjs/src/index.server.ts +++ b/packages/nextjs/src/index.server.ts @@ -118,9 +118,6 @@ function addServerIntegrations(options: NextjsOptions): void { }); integrations = addOrUpdateIntegration(defaultRewriteFramesIntegration, integrations); - const defaultRequestDataIntegration = new Integrations.RequestData(); - integrations = addOrUpdateIntegration(defaultRequestDataIntegration, integrations); - if (hasTracingEnabled(options)) { const defaultHttpTracingIntegration = new Integrations.Http({ tracing: true }); integrations = addOrUpdateIntegration(defaultHttpTracingIntegration, integrations, { diff --git a/packages/nextjs/test/index.server.test.ts b/packages/nextjs/test/index.server.test.ts index 827a4be6d73c..08d4178deb5b 100644 --- a/packages/nextjs/test/index.server.test.ts +++ b/packages/nextjs/test/index.server.test.ts @@ -148,10 +148,8 @@ describe('Server init()', () => { const nodeInitOptions = nodeInit.mock.calls[0][0] as ModifiedInitOptions; const rewriteFramesIntegration = findIntegrationByName(nodeInitOptions.integrations, 'RewriteFrames'); - const requestDataIntegration = findIntegrationByName(nodeInitOptions.integrations, 'RequestData'); expect(rewriteFramesIntegration).toBeDefined(); - expect(requestDataIntegration).toBeDefined(); }); it('supports passing unrelated integrations through options', () => {