diff --git a/packages/hub/src/scope.ts b/packages/hub/src/scope.ts index 4f72afa34a61..5a05e447b4ca 100644 --- a/packages/hub/src/scope.ts +++ b/packages/hub/src/scope.ts @@ -34,10 +34,9 @@ import { import { updateSession } from './session'; /** - * Absolute maximum number of breadcrumbs added to an event. - * The `maxBreadcrumbs` option cannot be higher than this value. + * Default value for maximum number of breadcrumbs added to an event. */ -const MAX_BREADCRUMBS = 100; +const DEFAULT_MAX_BREADCRUMBS = 100; /** * Holds additional event information. {@link Scope.applyToEvent} will be @@ -392,7 +391,7 @@ export class Scope implements ScopeInterface { * @inheritDoc */ public addBreadcrumb(breadcrumb: Breadcrumb, maxBreadcrumbs?: number): this { - const maxCrumbs = typeof maxBreadcrumbs === 'number' ? Math.min(maxBreadcrumbs, MAX_BREADCRUMBS) : MAX_BREADCRUMBS; + const maxCrumbs = typeof maxBreadcrumbs === 'number' ? maxBreadcrumbs : DEFAULT_MAX_BREADCRUMBS; // No data has been changed, so don't notify scope listeners if (maxCrumbs <= 0) { diff --git a/packages/hub/test/scope.test.ts b/packages/hub/test/scope.test.ts index 1bad52db6d9f..d5584f38e596 100644 --- a/packages/hub/test/scope.test.ts +++ b/packages/hub/test/scope.test.ts @@ -75,12 +75,12 @@ describe('Scope', () => { expect((scope as any)._breadcrumbs).toHaveLength(5); }); - test('addBreadcrumb cannot go over MAX_BREADCRUMBS value', () => { + test('addBreadcrumb can go over DEFAULT_MAX_BREADCRUMBS value', () => { const scope = new Scope(); - for (let i = 0; i < 111; i++) { + for (let i = 0; i < 120; i++) { scope.addBreadcrumb({ message: 'test' }, 111); } - expect((scope as any)._breadcrumbs).toHaveLength(100); + expect((scope as any)._breadcrumbs).toHaveLength(111); }); test('setLevel', () => { diff --git a/packages/types/src/options.ts b/packages/types/src/options.ts index 9b8d26d1c7f8..e4641b97aab1 100644 --- a/packages/types/src/options.ts +++ b/packages/types/src/options.ts @@ -93,7 +93,7 @@ export interface ClientOptions