From 86eb90284e3fa1ec2234f6c04ffd15af58440140 Mon Sep 17 00:00:00 2001 From: Markus Unterwaditzer Date: Thu, 23 Jun 2022 21:34:02 +0200 Subject: [PATCH 1/2] fix: Report the right units for CLS and TTFB --- packages/tracing/src/browser/metrics/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/tracing/src/browser/metrics/index.ts b/packages/tracing/src/browser/metrics/index.ts index d036a1d47494..bb807ea8afc1 100644 --- a/packages/tracing/src/browser/metrics/index.ts +++ b/packages/tracing/src/browser/metrics/index.ts @@ -50,7 +50,7 @@ function _trackCLS(): void { } __DEBUG_BUILD__ && logger.log('[Measurements] Adding CLS'); - _measurements['cls'] = { value: metric.value, unit: 'millisecond' }; + _measurements['cls'] = { value: metric.value }; _clsEntry = entry as LayoutShift; }); } @@ -172,7 +172,7 @@ export function addPerformanceEntries(transaction: Transaction): void { // This is the time between the start of the request and the start of the response in milliseconds. _measurements['ttfb.requestTime'] = { value: (responseStartTimestamp - requestStartTimestamp) * 1000, - unit: 'second', + unit: 'millisecond', }; } } From 545128482081d63fe5a7d98403ccba7f3ae604aa Mon Sep 17 00:00:00 2001 From: Markus Unterwaditzer Date: Thu, 23 Jun 2022 21:41:24 +0200 Subject: [PATCH 2/2] Update packages/tracing/src/browser/metrics/index.ts --- packages/tracing/src/browser/metrics/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/tracing/src/browser/metrics/index.ts b/packages/tracing/src/browser/metrics/index.ts index bb807ea8afc1..3e011c19d823 100644 --- a/packages/tracing/src/browser/metrics/index.ts +++ b/packages/tracing/src/browser/metrics/index.ts @@ -50,7 +50,7 @@ function _trackCLS(): void { } __DEBUG_BUILD__ && logger.log('[Measurements] Adding CLS'); - _measurements['cls'] = { value: metric.value }; + _measurements['cls'] = { value: metric.value, unit: 'none' }; _clsEntry = entry as LayoutShift; }); }