From d625fb868fdaaed1490be6d82c2b5f98f0752766 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Thu, 13 Jun 2024 16:34:45 +0200 Subject: [PATCH 1/2] ci: Fix node dependencies Ensure we run node-integration, remix, nextjs tests for changes in opentelemetry package. --- .github/workflows/build.yml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 53b8f9e32e52..ef02c4c47a4c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -119,18 +119,22 @@ jobs: node: - *shared - 'packages/node/**' + - 'packages/opentelemetry/**' + node_integration: + - *shared + - *node - 'dev-packages/node-integration-tests/**' nextjs: - *shared - *browser + - *node - 'packages/nextjs/**' - - 'packages/node/**' - 'packages/react/**' remix: - *shared - *browser + - *node - 'packages/remix/**' - - 'packages/node/**' - 'packages/react/**' profiling_node: - *shared @@ -157,6 +161,7 @@ jobs: changed_ember: ${{ steps.changed.outputs.ember }} changed_remix: ${{ steps.changed.outputs.remix }} changed_node: ${{ steps.changed.outputs.node }} + changed_node_integration: ${{ steps.changed.outputs.node_integration }} changed_profiling_node: ${{ steps.changed.outputs.profiling_node }} changed_profiling_node_bindings: ${{ steps.changed.outputs.profiling_node_bindings }} changed_deno: ${{ steps.changed.outputs.deno }} @@ -862,7 +867,7 @@ jobs: Node (${{ matrix.node }})${{ (matrix.typescript && format(' (TS {0})', matrix.typescript)) || '' }} Integration Tests needs: [job_get_metadata, job_build] - if: needs.job_get_metadata.outputs.changed_node == 'true' || github.event_name != 'pull_request' + if: needs.job_get_metadata.outputs.changed_node_integration == 'true' || github.event_name != 'pull_request' runs-on: ubuntu-20.04 timeout-minutes: 15 strategy: From b389834d6817e5e64cc9860ed882011574be13fa Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Thu, 13 Jun 2024 16:37:59 +0200 Subject: [PATCH 2/2] fix it --- .github/workflows/build.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ef02c4c47a4c..2286ff92505d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -108,6 +108,10 @@ jobs: - 'packages/replay-canvas/**' - 'packages/feedback/**' - 'packages/wasm/**' + node: &node + - *shared + - 'packages/node/**' + - 'packages/opentelemetry/**' browser_integration: - *shared - *browser @@ -116,10 +120,6 @@ jobs: - *shared - *browser - 'packages/ember/**' - node: - - *shared - - 'packages/node/**' - - 'packages/opentelemetry/**' node_integration: - *shared - *node