From 2b152c1bf327063c5bf7887a7d88fe35137f667e Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Wed, 5 Jun 2024 09:05:10 +0000 Subject: [PATCH 1/2] fix(nextjs): Update argument name in log message about `sentry` property on Next.js config object --- .../create-next-app/next.config.js | 38 +------------------ .../nextjs/src/config/withSentryConfig.ts | 2 +- 2 files changed, 2 insertions(+), 38 deletions(-) diff --git a/dev-packages/e2e-tests/test-applications/create-next-app/next.config.js b/dev-packages/e2e-tests/test-applications/create-next-app/next.config.js index efd4c00feec6..abf3b64a61d0 100644 --- a/dev-packages/e2e-tests/test-applications/create-next-app/next.config.js +++ b/dev-packages/e2e-tests/test-applications/create-next-app/next.config.js @@ -1,39 +1,3 @@ -// This file sets a custom webpack configuration to use your Next.js app -// with Sentry. -// https://nextjs.org/docs/api-reference/next.config.js/introduction -// https://docs.sentry.io/platforms/javascript/guides/nextjs/ - const { withSentryConfig } = require('@sentry/nextjs'); -const moduleExports = { - // Your existing module.exports - - sentry: { - // Use `hidden-source-map` rather than `source-map` as the Webpack `devtool` - // for client-side builds. (This will be the default starting in - // `@sentry/nextjs` version 8.0.0.) See - // https://webpack.js.org/configuration/devtool/ and - // https://docs.sentry.io/platforms/javascript/guides/nextjs/manual-setup/#use-hidden-source-map - // for more information. - hideSourceMaps: true, - }, -}; - -const sentryWebpackPluginOptions = { - // Additional config options for the Sentry Webpack plugin. Keep in mind that - // the following options are set automatically, and overriding them is not - // recommended: - // release, url, org, project, authToken, configFile, stripPrefix, - // urlPrefix, include, ignore - - silent: true, // Suppresses all logs - // For all available options, see: - // https://github.com/getsentry/sentry-webpack-plugin#options. - - // We're not testing source map uploads at the moment. - dryRun: true, -}; - -// Make sure adding Sentry options is the last code to run before exporting, to -// ensure that your source maps include changes from all other Webpack plugins -module.exports = withSentryConfig(moduleExports, sentryWebpackPluginOptions); +module.exports = withSentryConfig(nextConfig); diff --git a/packages/nextjs/src/config/withSentryConfig.ts b/packages/nextjs/src/config/withSentryConfig.ts index ec9115b4ce3e..d5fc6ee56304 100644 --- a/packages/nextjs/src/config/withSentryConfig.ts +++ b/packages/nextjs/src/config/withSentryConfig.ts @@ -51,7 +51,7 @@ function getFinalConfigObject( if ('sentry' in incomingUserNextConfigObject) { // eslint-disable-next-line no-console console.warn( - '[@sentry/nextjs] Setting a `sentry` property on the Next.js config is no longer supported. Please use the `sentrySDKOptions` argument of `withSentryConfig` instead.', + '[@sentry/nextjs] Setting a `sentry` property on the Next.js config object as a means of configuration is no longer supported. Please use the `sentryBuildOptions` argument of of the `withSentryConfig()` function instead.', ); // Next 12.2.3+ warns about non-canonical properties on `userNextConfig`. From 5f07c6e0e43077c91a6891eb615be05e34eb08b6 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Wed, 5 Jun 2024 09:26:33 +0000 Subject: [PATCH 2/2] woops --- .../e2e-tests/test-applications/create-next-app/next.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-packages/e2e-tests/test-applications/create-next-app/next.config.js b/dev-packages/e2e-tests/test-applications/create-next-app/next.config.js index abf3b64a61d0..5de673a830d7 100644 --- a/dev-packages/e2e-tests/test-applications/create-next-app/next.config.js +++ b/dev-packages/e2e-tests/test-applications/create-next-app/next.config.js @@ -1,3 +1,3 @@ const { withSentryConfig } = require('@sentry/nextjs'); -module.exports = withSentryConfig(nextConfig); +module.exports = withSentryConfig();