From 467aa22a8a4a45bb3650297555ed34f1c3b2dc5d Mon Sep 17 00:00:00 2001 From: Ryan Albrecht Date: Thu, 30 May 2024 11:55:02 -0700 Subject: [PATCH 1/2] fix(feedback): Wait for document to be ready before doing autoinject --- packages/feedback/src/core/integration.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/feedback/src/core/integration.ts b/packages/feedback/src/core/integration.ts index 203b98e0823a..4162057fb95c 100644 --- a/packages/feedback/src/core/integration.ts +++ b/packages/feedback/src/core/integration.ts @@ -276,7 +276,12 @@ export const buildFeedbackIntegration = ({ return; } - _createActor().appendToDom(); + const actor = _createActor(); + if (DOCUMENT.readyState === 'loading') { + DOCUMENT.addEventListener('DOMContentLoaded', actor.appendToDom); + } else { + actor.appendToDom(); + } }, /** From 7bd05cb84236e628e119bf45d6ebd2c03d50a2e5 Mon Sep 17 00:00:00 2001 From: Ryan Albrecht Date: Thu, 30 May 2024 13:27:06 -0700 Subject: [PATCH 2/2] dont get fancy, _createActor appends to the DOM too, so it needs to be deferred --- packages/feedback/src/core/integration.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/feedback/src/core/integration.ts b/packages/feedback/src/core/integration.ts index 4162057fb95c..652151fa8a89 100644 --- a/packages/feedback/src/core/integration.ts +++ b/packages/feedback/src/core/integration.ts @@ -276,11 +276,10 @@ export const buildFeedbackIntegration = ({ return; } - const actor = _createActor(); if (DOCUMENT.readyState === 'loading') { - DOCUMENT.addEventListener('DOMContentLoaded', actor.appendToDom); + DOCUMENT.addEventListener('DOMContentLoaded', () => _createActor().appendToDom); } else { - actor.appendToDom(); + _createActor().appendToDom(); } },