From b8dcbfdac4efd4eef10f4b104388638b124a54e7 Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Thu, 28 Mar 2024 17:33:52 -0400 Subject: [PATCH 1/2] ref(gcp-serverless): Remove setting `.__sentry_transaction --- packages/google-cloud-serverless/src/gcpfunction/http.ts | 8 -------- 1 file changed, 8 deletions(-) diff --git a/packages/google-cloud-serverless/src/gcpfunction/http.ts b/packages/google-cloud-serverless/src/gcpfunction/http.ts index 6ce957884ea9..f0950e90050d 100644 --- a/packages/google-cloud-serverless/src/gcpfunction/http.ts +++ b/packages/google-cloud-serverless/src/gcpfunction/http.ts @@ -59,14 +59,6 @@ function _wrapHttpFunction(fn: HttpFunction, options: Partial): request: req, }); - if (span instanceof Transaction) { - // We also set __sentry_transaction on the response so people can grab the transaction there to add - // spans to it later. - // TODO(v8): Remove this - // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access - (res as any).__sentry_transaction = span; - } - // eslint-disable-next-line @typescript-eslint/unbound-method const _end = res.end; // eslint-disable-next-line @typescript-eslint/no-explicit-any From 4a188da708cc07ea8c25cabde0c4730148f139fa Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Wed, 3 Apr 2024 09:12:12 -0400 Subject: [PATCH 2/2] transaction --- packages/google-cloud-serverless/src/gcpfunction/http.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/google-cloud-serverless/src/gcpfunction/http.ts b/packages/google-cloud-serverless/src/gcpfunction/http.ts index f0950e90050d..4a27bae2ecf9 100644 --- a/packages/google-cloud-serverless/src/gcpfunction/http.ts +++ b/packages/google-cloud-serverless/src/gcpfunction/http.ts @@ -1,7 +1,6 @@ import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, - Transaction, handleCallbackErrors, setHttpStatus, } from '@sentry/core';