diff --git a/packages/core/src/tracing/transaction.ts b/packages/core/src/tracing/transaction.ts index a95fe7c394f9..2469594ad687 100644 --- a/packages/core/src/tracing/transaction.ts +++ b/packages/core/src/tracing/transaction.ts @@ -97,9 +97,6 @@ export class Transaction extends SentrySpan implements TransactionInterface { public get metadata(): TransactionMetadata { // We merge attributes in for backwards compatibility return { - // Defaults - spanMetadata: {}, - // Legacy metadata ...this._metadata, diff --git a/packages/core/test/lib/tracing/transaction.test.ts b/packages/core/test/lib/tracing/transaction.test.ts index 781b9bdc1472..aebdc7933fed 100644 --- a/packages/core/test/lib/tracing/transaction.test.ts +++ b/packages/core/test/lib/tracing/transaction.test.ts @@ -32,15 +32,12 @@ describe('transaction', () => { /* eslint-disable deprecation/deprecation */ it('works with defaults', () => { const transaction = new Transaction({ name: 'span name' }); - expect(transaction.metadata).toEqual({ - spanMetadata: {}, - }); + expect(transaction.metadata).toEqual({}); }); it('allows to set metadata in constructor', () => { const transaction = new Transaction({ name: 'span name', metadata: { request: {} } }); expect(transaction.metadata).toEqual({ - spanMetadata: {}, request: {}, }); }); @@ -57,7 +54,6 @@ describe('transaction', () => { expect(transaction.metadata).toEqual({ sampleRate: 0.5, - spanMetadata: {}, request: {}, }); @@ -74,7 +70,6 @@ describe('transaction', () => { transaction.setMetadata({ request: {} }); expect(transaction.metadata).toEqual({ - spanMetadata: {}, request: {}, }); }); diff --git a/packages/replay-internal/test/fixtures/transaction.ts b/packages/replay-internal/test/fixtures/transaction.ts index a732c3c0dbb1..6264802f74d8 100644 --- a/packages/replay-internal/test/fixtures/transaction.ts +++ b/packages/replay-internal/test/fixtures/transaction.ts @@ -115,112 +115,6 @@ export function Transaction(traceId?: string, obj?: Partial): any { trace_id: '3e0ff8aff4dc4236a80b77a37ef66c7d', sample_rate: '1', }, - spanMetadata: { - '9ea106e8efbce4a0': { - logMessage: - "[Tracing] Starting 'ui.react.mount' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - b4c7b421761d903a: { - logMessage: - "[Tracing] Starting 'ui.react.update' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - '808967f15cae9251': { - logMessage: - "[Tracing] Starting 'ui.long-task' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - '9a0de85dfd88085c': { - logMessage: - "[Tracing] Starting 'ui.react.render' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - '863c6099f1929910': { - logMessage: - "[Tracing] Starting 'ui.react.update' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - '87497c337838d561': { - logMessage: - "[Tracing] Starting 'http.client' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - '81638bb5251f9e3f': { - logMessage: - "[Tracing] Starting 'http.client' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - bf25ff92b2dc7498: { - logMessage: - "[Tracing] Starting 'ui.long-task' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - a7c3320e88b04076: { - logMessage: - "[Tracing] Starting 'ui.react.update' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - '95c892e987b8e0f5': { - logMessage: - "[Tracing] Starting 'ui.long-task' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - b734c15c4d94b7b6: { - logMessage: - "[Tracing] Starting 'ui.long-task' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - '934881bfe9a8e043': { - logMessage: - "[Tracing] Starting 'http.client' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - '9bc8a019012e4692': { - logMessage: - "[Tracing] Starting 'resource.script' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - b3c5eb78c15aa492: { - logMessage: - "[Tracing] Starting 'resource.script' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - '84a72c34a78232b7': { - logMessage: - "[Tracing] Starting 'resource.script' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - b523103902ac1f0d: { - logMessage: - "[Tracing] Starting 'resource.script' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - '84f863de30175a64': { - logMessage: - "[Tracing] Starting 'resource.script' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - b0532b585ec47f05: { - logMessage: - "[Tracing] Starting 'resource.script' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - '9c3612dc22c5aea5': { - logMessage: - "[Tracing] Starting 'resource.script' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - '82b74a44ef06ae13': { - logMessage: - "[Tracing] Starting 'resource.script' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - b2d11e8d407329fd: { - logMessage: - "[Tracing] Starting 'resource.script' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - '98146db11c338f31': { - logMessage: - "[Tracing] Starting 'resource.script' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - a05774f4b2885c47: { - logMessage: - "[Tracing] Starting 'resource.script' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - a0c0d4f8ec6bfcd7: { - logMessage: - "[Tracing] Starting 'resource.script' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - ab2e6ef0852bfc64: { - logMessage: - "[Tracing] Starting 'resource.script' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - b7fad2cd42783af4: { - logMessage: - "[Tracing] Starting 'resource.other' span on transaction '/organizations/:orgId/replays/:replaySlug/' (b44b173b1c74a782).", - }, - }, sampleRate: 1, }, // }}} transaction_info: { diff --git a/packages/types/src/transaction.ts b/packages/types/src/transaction.ts index 533401455488..d3db4afe0add 100644 --- a/packages/types/src/transaction.ts +++ b/packages/types/src/transaction.ts @@ -186,12 +186,6 @@ export interface TransactionMetadata { /** For transactions tracing server-side request handling, the path of the request being tracked. */ /** TODO: If we rm -rf `instrumentServer`, this can go, too */ requestPath?: string; - - /** - * Metadata for the transaction's spans, keyed by spanId. - * @deprecated This will be removed in v8. - */ - spanMetadata: { [spanId: string]: { [key: string]: unknown } }; } /**