From eb03f954481836564ce62f25e695a930e3261c84 Mon Sep 17 00:00:00 2001 From: s1gr1d Date: Tue, 19 Mar 2024 16:36:33 +0100 Subject: [PATCH 1/2] bump to es2018 --- .eslintrc.js | 2 +- MIGRATION.md | 14 +++++++------- .../create-next-app/tsconfig.json | 2 +- .../create-react-app/tsconfig.json | 2 +- .../test-applications/generic-ts3.8/tsconfig.json | 4 ++-- .../test-applications/nextjs-14/tsconfig.json | 2 +- .../test-applications/nextjs-app-dir/tsconfig.json | 2 +- .../node-exports-test-app/tsconfig.json | 2 +- .../node-express-app/tsconfig.json | 2 +- .../react-create-hash-router/tsconfig.json | 2 +- .../react-router-6-use-routes/tsconfig.json | 2 +- .../standard-frontend-react/tsconfig.json | 2 +- dev-packages/rollup-utils/npmHelpers.mjs | 2 +- packages/angular/tsconfig.ngc.json | 4 ++-- packages/nextjs/test/integration/tsconfig.json | 2 +- packages/node-experimental/tsconfig.json | 2 +- packages/node/tsconfig.json | 2 +- packages/profiling-node/tsconfig.json | 2 +- packages/replay-worker/tsconfig.json | 2 +- packages/types/tsconfig.json | 2 +- packages/typescript/tsconfig.json | 4 ++-- 21 files changed, 30 insertions(+), 30 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 90f474319c7d..a2ff5d739d88 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -6,7 +6,7 @@ module.exports = { root: true, env: { - es2017: true, + es2018: true, }, parserOptions: { ecmaVersion: 2018, diff --git a/MIGRATION.md b/MIGRATION.md index 1daf6c3d5c8d..f11ba0b59c42 100644 --- a/MIGRATION.md +++ b/MIGRATION.md @@ -24,18 +24,18 @@ stable release of `8.x` comes out). to `@sentry/node` and all of our node-based server-side sdks (`@sentry/nextjs`, `@sentry/serverless`, etc.). We no longer test against Node 8, 10, or 12 and cannot guarantee that the SDK will work as expected on these versions. -**Browser**: Our browser SDKs (`@sentry/browser`, `@sentry/react`, `@sentry/vue`, etc.) now require ES2017+ compatible +**Browser**: Our browser SDKs (`@sentry/browser`, `@sentry/react`, `@sentry/vue`, etc.) now require ES2018+ compatible browsers. This means that we no longer support IE11 (end of an era). This also means that the Browser SDK requires the fetch API to be available in the environment. New minimum supported browsers: -- Chrome 58 -- Edge 15 -- Safari/iOS Safari 11 -- Firefox 54 -- Opera 45 -- Samsung Internet 7.2 +- Chrome 63 +- Edge 79 +- Safari/iOS Safari 12 +- Firefox 58 +- Opera 50 +- Samsung Internet 8.2 For IE11 support please transpile your code to ES5 using babel or similar and add required polyfills. diff --git a/dev-packages/e2e-tests/test-applications/create-next-app/tsconfig.json b/dev-packages/e2e-tests/test-applications/create-next-app/tsconfig.json index 1fd2e9a8d510..73c09112c46a 100644 --- a/dev-packages/e2e-tests/test-applications/create-next-app/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/create-next-app/tsconfig.json @@ -1,6 +1,6 @@ { "compilerOptions": { - "target": "es2017", + "target": "es2018", "lib": ["dom", "dom.iterable", "esnext"], "allowJs": true, "skipLibCheck": true, diff --git a/dev-packages/e2e-tests/test-applications/create-react-app/tsconfig.json b/dev-packages/e2e-tests/test-applications/create-react-app/tsconfig.json index bd19e4f07fc7..0e8eacbd8d09 100644 --- a/dev-packages/e2e-tests/test-applications/create-react-app/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/create-react-app/tsconfig.json @@ -1,6 +1,6 @@ { "compilerOptions": { - "target": "es2017", + "target": "es2018", "lib": ["dom", "dom.iterable", "esnext"], "allowJs": true, "skipLibCheck": true, diff --git a/dev-packages/e2e-tests/test-applications/generic-ts3.8/tsconfig.json b/dev-packages/e2e-tests/test-applications/generic-ts3.8/tsconfig.json index ef27756e97d9..95de9c93fc38 100644 --- a/dev-packages/e2e-tests/test-applications/generic-ts3.8/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/generic-ts3.8/tsconfig.json @@ -1,11 +1,11 @@ { "include": ["index.ts"], "compilerOptions": { - "lib": ["es2017", "DOM"], + "lib": ["es2018", "DOM"], "skipLibCheck": false, "noEmit": true, "types": [], - "target": "es2017", + "target": "es2018", "moduleResolution": "node" } } diff --git a/dev-packages/e2e-tests/test-applications/nextjs-14/tsconfig.json b/dev-packages/e2e-tests/test-applications/nextjs-14/tsconfig.json index 6b81123d463c..f5a1f45a97e1 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-14/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/nextjs-14/tsconfig.json @@ -1,6 +1,6 @@ { "compilerOptions": { - "target": "es2017", + "target": "es2018", "lib": ["dom", "dom.iterable", "esnext"], "allowJs": true, "skipLibCheck": true, diff --git a/dev-packages/e2e-tests/test-applications/nextjs-app-dir/tsconfig.json b/dev-packages/e2e-tests/test-applications/nextjs-app-dir/tsconfig.json index 6b81123d463c..f5a1f45a97e1 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-app-dir/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/nextjs-app-dir/tsconfig.json @@ -1,6 +1,6 @@ { "compilerOptions": { - "target": "es2017", + "target": "es2018", "lib": ["dom", "dom.iterable", "esnext"], "allowJs": true, "skipLibCheck": true, diff --git a/dev-packages/e2e-tests/test-applications/node-exports-test-app/tsconfig.json b/dev-packages/e2e-tests/test-applications/node-exports-test-app/tsconfig.json index 6f37f0817c4a..e1f37178feb7 100644 --- a/dev-packages/e2e-tests/test-applications/node-exports-test-app/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/node-exports-test-app/tsconfig.json @@ -2,7 +2,7 @@ "compilerOptions": { "types": ["node"], "esModuleInterop": true, - "lib": ["es2017"], + "lib": ["es2018"], "strict": true, "outDir": "dist", "target": "ESNext", diff --git a/dev-packages/e2e-tests/test-applications/node-express-app/tsconfig.json b/dev-packages/e2e-tests/test-applications/node-express-app/tsconfig.json index d46ae8103211..8cb64e989ed9 100644 --- a/dev-packages/e2e-tests/test-applications/node-express-app/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/node-express-app/tsconfig.json @@ -2,7 +2,7 @@ "compilerOptions": { "types": ["node"], "esModuleInterop": true, - "lib": ["es2017"], + "lib": ["es2018"], "strict": true, "outDir": "dist" }, diff --git a/dev-packages/e2e-tests/test-applications/react-create-hash-router/tsconfig.json b/dev-packages/e2e-tests/test-applications/react-create-hash-router/tsconfig.json index 75ae036f46b0..4cc95dc2689a 100644 --- a/dev-packages/e2e-tests/test-applications/react-create-hash-router/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/react-create-hash-router/tsconfig.json @@ -1,6 +1,6 @@ { "compilerOptions": { - "target": "es2017", + "target": "es2018", "lib": ["dom", "dom.iterable", "esnext"], "allowJs": true, "skipLibCheck": true, diff --git a/dev-packages/e2e-tests/test-applications/react-router-6-use-routes/tsconfig.json b/dev-packages/e2e-tests/test-applications/react-router-6-use-routes/tsconfig.json index 75ae036f46b0..4cc95dc2689a 100644 --- a/dev-packages/e2e-tests/test-applications/react-router-6-use-routes/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/react-router-6-use-routes/tsconfig.json @@ -1,6 +1,6 @@ { "compilerOptions": { - "target": "es2017", + "target": "es2018", "lib": ["dom", "dom.iterable", "esnext"], "allowJs": true, "skipLibCheck": true, diff --git a/dev-packages/e2e-tests/test-applications/standard-frontend-react/tsconfig.json b/dev-packages/e2e-tests/test-applications/standard-frontend-react/tsconfig.json index 75ae036f46b0..4cc95dc2689a 100644 --- a/dev-packages/e2e-tests/test-applications/standard-frontend-react/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/standard-frontend-react/tsconfig.json @@ -1,6 +1,6 @@ { "compilerOptions": { - "target": "es2017", + "target": "es2018", "lib": ["dom", "dom.iterable", "esnext"], "allowJs": true, "skipLibCheck": true, diff --git a/dev-packages/rollup-utils/npmHelpers.mjs b/dev-packages/rollup-utils/npmHelpers.mjs index 58bb4d75edf7..36ff6143936b 100644 --- a/dev-packages/rollup-utils/npmHelpers.mjs +++ b/dev-packages/rollup-utils/npmHelpers.mjs @@ -59,7 +59,7 @@ export function makeBaseNPMConfig(options = {}) { // output individual files rather than one big bundle preserveModules: true, - // Allow wrappers or helper functions generated by rollup to use any ES6 features except symbols. (Symbols in + // Allow wrappers or helper functions generated by rollup to use any ES2015 features except symbols. (Symbols in // general are fine, but the `[Symbol.toStringTag]: 'Module'` which Rollup adds alongside `__esModule: // true` in CJS modules makes it so that Jest <= 29.2.2 crashes when trying to mock generated `@sentry/xxx` // packages. See https://github.com/getsentry/sentry-javascript/pull/6043.) diff --git a/packages/angular/tsconfig.ngc.json b/packages/angular/tsconfig.ngc.json index 096ced563bba..e915bd8cc32c 100644 --- a/packages/angular/tsconfig.ngc.json +++ b/packages/angular/tsconfig.ngc.json @@ -5,9 +5,9 @@ { "extends": "./tsconfig.json", "compilerOptions": { - "target": "es2017", + "target": "es2018", "declarationMap": false, - "lib": ["dom", "es2017"], + "lib": ["dom", "es2018"], "baseUrl": "./" }, "angularCompilerOptions": { diff --git a/packages/nextjs/test/integration/tsconfig.json b/packages/nextjs/test/integration/tsconfig.json index 49a874193c18..ed3ebdb2baea 100644 --- a/packages/nextjs/test/integration/tsconfig.json +++ b/packages/nextjs/test/integration/tsconfig.json @@ -7,7 +7,7 @@ "forceConsistentCasingInFileNames": true, "isolatedModules": true, "jsx": "preserve", - "lib": ["dom", "es2017"], + "lib": ["dom", "es2018"], "module": "esnext", "moduleResolution": "node", "noEmit": true, diff --git a/packages/node-experimental/tsconfig.json b/packages/node-experimental/tsconfig.json index 5a6bb72e5fd3..8f38d240197e 100644 --- a/packages/node-experimental/tsconfig.json +++ b/packages/node-experimental/tsconfig.json @@ -4,7 +4,7 @@ "include": ["src/**/*"], "compilerOptions": { - "lib": ["es2017"], + "lib": ["es2018"], "module": "Node16" } } diff --git a/packages/node/tsconfig.json b/packages/node/tsconfig.json index d38a5701a2bf..89a9b9e0e2fe 100644 --- a/packages/node/tsconfig.json +++ b/packages/node/tsconfig.json @@ -4,6 +4,6 @@ "include": ["src/**/*"], "compilerOptions": { - "lib": ["es2017"] + "lib": ["es2018"] } } diff --git a/packages/profiling-node/tsconfig.json b/packages/profiling-node/tsconfig.json index 03da9a484924..c53d22cf5270 100644 --- a/packages/profiling-node/tsconfig.json +++ b/packages/profiling-node/tsconfig.json @@ -2,7 +2,7 @@ "extends": "../../tsconfig.json", "compilerOptions": { "module": "esnext", - "lib": ["es2017"], + "lib": ["es2018"], "outDir": "lib", "types": ["node"] }, diff --git a/packages/replay-worker/tsconfig.json b/packages/replay-worker/tsconfig.json index dbacce80e01c..f3db9c003516 100644 --- a/packages/replay-worker/tsconfig.json +++ b/packages/replay-worker/tsconfig.json @@ -4,7 +4,7 @@ "module": "esnext", "lib": ["webworker", "scripthost"], "esModuleInterop": true, - "target": "es2017", + "target": "es2018", "strictPropertyInitialization": false }, "include": ["src/**/*.ts"] diff --git a/packages/types/tsconfig.json b/packages/types/tsconfig.json index d38a5701a2bf..89a9b9e0e2fe 100644 --- a/packages/types/tsconfig.json +++ b/packages/types/tsconfig.json @@ -4,6 +4,6 @@ "include": ["src/**/*"], "compilerOptions": { - "lib": ["es2017"] + "lib": ["es2018"] } } diff --git a/packages/typescript/tsconfig.json b/packages/typescript/tsconfig.json index 8f773bca55e3..d2457663e802 100644 --- a/packages/typescript/tsconfig.json +++ b/packages/typescript/tsconfig.json @@ -7,7 +7,7 @@ "importHelpers": true, "inlineSources": true, "isolatedModules": true, - "lib": ["es2017", "dom"], + "lib": ["es2018", "dom"], "moduleResolution": "node", "noErrorTruncation": true, "noFallthroughCasesInSwitch": true, @@ -19,6 +19,6 @@ "sourceMap": true, "strict": true, "strictBindCallApply": false, - "target": "es2017" + "target": "es2018" } } From 5d3e738d68337169ab55f1166ba46d467a8db759 Mon Sep 17 00:00:00 2001 From: s1gr1d Date: Fri, 22 Mar 2024 11:08:04 +0100 Subject: [PATCH 2/2] set env to es2017 --- .eslintrc.js | 2 +- yarn.lock | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.eslintrc.js b/.eslintrc.js index a2ff5d739d88..90f474319c7d 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -6,7 +6,7 @@ module.exports = { root: true, env: { - es2018: true, + es2017: true, }, parserOptions: { ecmaVersion: 2018, diff --git a/yarn.lock b/yarn.lock index 644e37903884..5064a198aea8 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6713,6 +6713,7 @@ "@types/unist" "*" "@types/history-4@npm:@types/history@4.7.8", "@types/history-5@npm:@types/history@4.7.8", "@types/history@*": + name "@types/history-4" version "4.7.8" resolved "https://registry.yarnpkg.com/@types/history/-/history-4.7.8.tgz#49348387983075705fe8f4e02fb67f7daaec4934" integrity sha512-S78QIYirQcUoo6UJZx9CSP0O2ix9IaeAXwQi26Rhr/+mg7qqPy8TzaxHSUut7eGjL8WmLccT7/MXf304WjqHcA== @@ -25288,6 +25289,7 @@ react-is@^18.0.0: "@remix-run/router" "1.0.2" "react-router-6@npm:react-router@6.3.0", react-router@6.3.0: + name react-router-6 version "6.3.0" resolved "https://registry.yarnpkg.com/react-router/-/react-router-6.3.0.tgz#3970cc64b4cb4eae0c1ea5203a80334fdd175557" integrity sha512-7Wh1DzVQ+tlFjkeo+ujvjSqSJmkt1+8JO+T5xklPlgrh70y7ogx75ODRW0ThWhY7S+6yEDks8TYrtQe/aoboBQ==