From 80a9ef6d1a4e00c182b13ce99c4b736e5b54815b Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Thu, 14 Mar 2024 17:52:16 -0400 Subject: [PATCH 1/4] test(replay): Skip flaky replay integration tests --- .../fetch/captureRequestHeaders/test.ts | 4 +++- .../extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts b/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts index 68296df30cdd..0b0b37fb1cf6 100644 --- a/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts +++ b/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts @@ -8,7 +8,9 @@ import { shouldSkipReplayTest, } from '../../../../../utils/replayHelpers'; -sentryTest('handles empty/missing request headers', async ({ getLocalTestPath, page, browserName }) => { +// Skipping because this test is flaky +// https://github.com/getsentry/sentry-javascript/issues/11062 +sentryTest.skip('handles empty/missing request headers', async ({ getLocalTestPath, page, browserName }) => { if (shouldSkipReplayTest()) { sentryTest.skip(); } diff --git a/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts b/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts index bc79df066246..52857d17479d 100644 --- a/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts +++ b/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts @@ -8,7 +8,9 @@ import { shouldSkipReplayTest, } from '../../../../../utils/replayHelpers'; -sentryTest('captures request body size when body is sent', async ({ getLocalTestPath, page }) => { +// Skipping because this test is flaky +// https://github.com/getsentry/sentry-javascript/issues/10395 +sentryTest.skip('captures request body size when body is sent', async ({ getLocalTestPath, page }) => { if (shouldSkipReplayTest()) { sentryTest.skip(); } From fe56cfc01ed9a9391655c31af11adef7e63cbff0 Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Thu, 14 Mar 2024 18:14:15 -0400 Subject: [PATCH 2/4] disable more tests --- .../fetch/captureRequestHeaders/test.ts | 4 +++- .../extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts b/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts index 0b0b37fb1cf6..b0fe518be7a1 100644 --- a/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts +++ b/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestHeaders/test.ts @@ -252,7 +252,9 @@ sentryTest('captures request headers on Request', async ({ getLocalTestPath, pag ]); }); -sentryTest('captures request headers as Headers instance', async ({ getLocalTestPath, page, browserName }) => { +// This test is flaky. +// See https://github.com/getsentry/sentry-javascript/pull/11110 +sentryTest.skip('captures request headers as Headers instance', async ({ getLocalTestPath, page, browserName }) => { if (shouldSkipReplayTest()) { sentryTest.skip(); } diff --git a/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts b/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts index 52857d17479d..089c76c06120 100644 --- a/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts +++ b/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts @@ -95,7 +95,9 @@ sentryTest.skip('captures request body size when body is sent', async ({ getLoca ]); }); -sentryTest('captures request size from non-text request body', async ({ getLocalTestPath, page }) => { +// This test is flaky. +// See https://github.com/getsentry/sentry-javascript/pull/11110 +sentryTest.skip('captures request size from non-text request body', async ({ getLocalTestPath, page }) => { if (shouldSkipReplayTest()) { sentryTest.skip(); } From 2c6020b8ada1d24c2f93bfb8ef0ff0fd216e3600 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Fri, 15 Mar 2024 09:30:46 +0000 Subject: [PATCH 3/4] Unskip non-flakey test --- .../fetch/captureRequestSize/test.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts b/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts index 089c76c06120..bc79df066246 100644 --- a/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts +++ b/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts @@ -8,9 +8,7 @@ import { shouldSkipReplayTest, } from '../../../../../utils/replayHelpers'; -// Skipping because this test is flaky -// https://github.com/getsentry/sentry-javascript/issues/10395 -sentryTest.skip('captures request body size when body is sent', async ({ getLocalTestPath, page }) => { +sentryTest('captures request body size when body is sent', async ({ getLocalTestPath, page }) => { if (shouldSkipReplayTest()) { sentryTest.skip(); } @@ -95,9 +93,7 @@ sentryTest.skip('captures request body size when body is sent', async ({ getLoca ]); }); -// This test is flaky. -// See https://github.com/getsentry/sentry-javascript/pull/11110 -sentryTest.skip('captures request size from non-text request body', async ({ getLocalTestPath, page }) => { +sentryTest('captures request size from non-text request body', async ({ getLocalTestPath, page }) => { if (shouldSkipReplayTest()) { sentryTest.skip(); } From e4ae858df866dba7fbd807227626bacac172aafe Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Fri, 15 Mar 2024 10:16:12 +0000 Subject: [PATCH 4/4] Revert "Unskip non-flakey test" This reverts commit 2c6020b8ada1d24c2f93bfb8ef0ff0fd216e3600. --- .../fetch/captureRequestSize/test.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts b/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts index bc79df066246..089c76c06120 100644 --- a/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts +++ b/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/fetch/captureRequestSize/test.ts @@ -8,7 +8,9 @@ import { shouldSkipReplayTest, } from '../../../../../utils/replayHelpers'; -sentryTest('captures request body size when body is sent', async ({ getLocalTestPath, page }) => { +// Skipping because this test is flaky +// https://github.com/getsentry/sentry-javascript/issues/10395 +sentryTest.skip('captures request body size when body is sent', async ({ getLocalTestPath, page }) => { if (shouldSkipReplayTest()) { sentryTest.skip(); } @@ -93,7 +95,9 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest ]); }); -sentryTest('captures request size from non-text request body', async ({ getLocalTestPath, page }) => { +// This test is flaky. +// See https://github.com/getsentry/sentry-javascript/pull/11110 +sentryTest.skip('captures request size from non-text request body', async ({ getLocalTestPath, page }) => { if (shouldSkipReplayTest()) { sentryTest.skip(); }