From b7c54570201dfdced29ac538c944560f7d54ffe2 Mon Sep 17 00:00:00 2001 From: Tim Fish Date: Thu, 29 Feb 2024 14:23:32 +0000 Subject: [PATCH] feat(node): Remove unnecessary URL imports --- packages/node-experimental/src/integrations/anr/index.ts | 1 - packages/node-experimental/src/integrations/spotlight.ts | 1 - .../node-experimental/src/integrations/tracing/hapi/types.ts | 3 +-- packages/node-experimental/src/proxy/helpers.ts | 2 -- packages/node-experimental/src/proxy/index.ts | 2 -- packages/node-experimental/src/transports/http-module.ts | 1 - packages/node-experimental/src/transports/http.ts | 1 - 7 files changed, 1 insertion(+), 10 deletions(-) diff --git a/packages/node-experimental/src/integrations/anr/index.ts b/packages/node-experimental/src/integrations/anr/index.ts index 2670f30db558..6e822e06b9a4 100644 --- a/packages/node-experimental/src/integrations/anr/index.ts +++ b/packages/node-experimental/src/integrations/anr/index.ts @@ -1,4 +1,3 @@ -import { URL } from 'url'; import { defineIntegration, getCurrentScope } from '@sentry/core'; import type { Contexts, Event, EventHint, IntegrationFn } from '@sentry/types'; import { logger } from '@sentry/utils'; diff --git a/packages/node-experimental/src/integrations/spotlight.ts b/packages/node-experimental/src/integrations/spotlight.ts index ebd8573c5072..21629ad340ac 100644 --- a/packages/node-experimental/src/integrations/spotlight.ts +++ b/packages/node-experimental/src/integrations/spotlight.ts @@ -1,5 +1,4 @@ import * as http from 'http'; -import { URL } from 'url'; import { defineIntegration } from '@sentry/core'; import type { Client, Envelope, IntegrationFn } from '@sentry/types'; import { logger, serializeEnvelope } from '@sentry/utils'; diff --git a/packages/node-experimental/src/integrations/tracing/hapi/types.ts b/packages/node-experimental/src/integrations/tracing/hapi/types.ts index a650667fe362..4da83f672076 100644 --- a/packages/node-experimental/src/integrations/tracing/hapi/types.ts +++ b/packages/node-experimental/src/integrations/tracing/hapi/types.ts @@ -19,7 +19,6 @@ // https://github.com/DefinitelyTyped/DefinitelyTyped/blob/c73060bd14bb74a2f1906ccfc714d385863bc07d/types/boom/v4/index.d.ts import type * as stream from 'stream'; -import type * as url from 'url'; interface Podium { new (events?: Events[]): Podium; @@ -214,7 +213,7 @@ interface Request extends Podium { readonly path: string; response: ResponseObject | Boom | null; readonly route: RequestRoute; - readonly url: url.Url; + readonly url: URL; } interface ResponseObjectHeaderOptions { diff --git a/packages/node-experimental/src/proxy/helpers.ts b/packages/node-experimental/src/proxy/helpers.ts index 119ffd9317ce..2fa5b84f6ccb 100644 --- a/packages/node-experimental/src/proxy/helpers.ts +++ b/packages/node-experimental/src/proxy/helpers.ts @@ -30,8 +30,6 @@ import * as http from 'http'; import * as https from 'https'; import type { Readable } from 'stream'; -// TODO (v8): Remove this when Node < 12 is no longer supported -import type { URL } from 'url'; export type ThenableRequest = http.ClientRequest & { then: Promise['then']; diff --git a/packages/node-experimental/src/proxy/index.ts b/packages/node-experimental/src/proxy/index.ts index 4129a9f65cd7..89c4f4f5b4a2 100644 --- a/packages/node-experimental/src/proxy/index.ts +++ b/packages/node-experimental/src/proxy/index.ts @@ -33,8 +33,6 @@ import type * as http from 'http'; import type { OutgoingHttpHeaders } from 'http'; import * as net from 'net'; import * as tls from 'tls'; -// TODO (v8): Remove this when Node < 12 is no longer supported -import { URL } from 'url'; import { logger } from '@sentry/utils'; import { Agent } from './base'; import type { AgentConnectOpts } from './base'; diff --git a/packages/node-experimental/src/transports/http-module.ts b/packages/node-experimental/src/transports/http-module.ts index b4dd0492f4fd..26bb37b6f4b9 100644 --- a/packages/node-experimental/src/transports/http-module.ts +++ b/packages/node-experimental/src/transports/http-module.ts @@ -1,6 +1,5 @@ import type { ClientRequest, IncomingHttpHeaders, RequestOptions as HTTPRequestOptions } from 'http'; import type { RequestOptions as HTTPSRequestOptions } from 'https'; -import type { URL } from 'url'; export type HTTPModuleRequestOptions = HTTPRequestOptions | HTTPSRequestOptions | string | URL; diff --git a/packages/node-experimental/src/transports/http.ts b/packages/node-experimental/src/transports/http.ts index 83d8bab5141a..532367578fb5 100644 --- a/packages/node-experimental/src/transports/http.ts +++ b/packages/node-experimental/src/transports/http.ts @@ -1,7 +1,6 @@ import * as http from 'http'; import * as https from 'https'; import { Readable } from 'stream'; -import { URL } from 'url'; import { createGzip } from 'zlib'; import { createTransport } from '@sentry/core'; import type {