From 4b2f4f252b91424b313fd4518a8e4ee23433c650 Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Wed, 21 Feb 2024 14:34:35 -0500 Subject: [PATCH] test(integration): Fix flakey test `replay/extendNetworkBreadcrumbs/xhr/captureRequestSize` [maybe] fixes this flakey test --- .../xhr/captureRequestSize/test.ts | 34 ++++++++++--------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestSize/test.ts b/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestSize/test.ts index d33d8a64f1c1..50709dc37705 100644 --- a/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestSize/test.ts +++ b/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestSize/test.ts @@ -36,23 +36,25 @@ sentryTest('captures request body size when body is sent', async ({ getLocalTest const url = await getLocalTestPath({ testDir: __dirname }); await page.goto(url); - void page.evaluate(() => { - /* eslint-disable */ - const xhr = new XMLHttpRequest(); - - xhr.open('POST', 'http://localhost:7654/foo'); - xhr.send('{"foo":"bar"}'); - - xhr.addEventListener('readystatechange', function () { - if (xhr.readyState === 4) { - // @ts-expect-error Sentry is a global - setTimeout(() => Sentry.captureException('test error', 0)); - } - }); - /* eslint-enable */ - }); + const [, request] = await Promise.all([ + page.evaluate(() => { + /* eslint-disable */ + const xhr = new XMLHttpRequest(); + + xhr.open('POST', 'http://localhost:7654/foo'); + xhr.send('{"foo":"bar"}'); + + xhr.addEventListener('readystatechange', function () { + if (xhr.readyState === 4) { + // @ts-expect-error Sentry is a global + setTimeout(() => Sentry.captureException('test error', 0)); + } + }); + /* eslint-enable */ + }), + requestPromise, + ]); - const request = await requestPromise; const eventData = envelopeRequestParser(request); expect(eventData.exception?.values).toHaveLength(1);