From 4f86ad837390a797a62f52f52a2f4f0d1fde0d79 Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Tue, 6 Feb 2024 17:05:14 -0500 Subject: [PATCH 1/2] test(browser-integration): Attempt to improve potentially flakey `slowClick -> windowOpen` test Maybe closes https://github.com/getsentry/sentry-javascript/issues/10377 --- .../suites/replay/slowClick/windowOpen/test.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/dev-packages/browser-integration-tests/suites/replay/slowClick/windowOpen/test.ts b/dev-packages/browser-integration-tests/suites/replay/slowClick/windowOpen/test.ts index c029f19b8c28..ee3c73e92699 100644 --- a/dev-packages/browser-integration-tests/suites/replay/slowClick/windowOpen/test.ts +++ b/dev-packages/browser-integration-tests/suites/replay/slowClick/windowOpen/test.ts @@ -28,11 +28,14 @@ sentryTest('window.open() is considered for slow click', async ({ getLocalTestUr // Ensure window.open() still works as expected const context = browser.contexts()[0]; - const waitForNewPage = context.waitForEvent('page'); - await page.locator('#windowOpenButton').click(); + const [ reqResponse1 ] = await Promise.all([ + reqPromise1, + context.waitForEvent('page'), + page.locator('#windowOpenButton').click(), + ]) - const { breadcrumbs } = getCustomRecordingEvents(await reqPromise1); + const { breadcrumbs } = getCustomRecordingEvents(reqResponse1); // Filter out potential blur breadcrumb, as otherwise this can be flaky const filteredBreadcrumb = breadcrumbs.filter(breadcrumb => breadcrumb.category !== 'ui.blur'); @@ -57,8 +60,6 @@ sentryTest('window.open() is considered for slow click', async ({ getLocalTestUr }, ]); - await waitForNewPage; - const pages = context.pages(); expect(pages.length).toBe(2); From 3f366fbde3dd07445d8637eff865d00a8a34844f Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Tue, 6 Feb 2024 17:26:25 -0500 Subject: [PATCH 2/2] lint --- .../suites/replay/slowClick/windowOpen/test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dev-packages/browser-integration-tests/suites/replay/slowClick/windowOpen/test.ts b/dev-packages/browser-integration-tests/suites/replay/slowClick/windowOpen/test.ts index ee3c73e92699..bb2c91018d94 100644 --- a/dev-packages/browser-integration-tests/suites/replay/slowClick/windowOpen/test.ts +++ b/dev-packages/browser-integration-tests/suites/replay/slowClick/windowOpen/test.ts @@ -29,11 +29,11 @@ sentryTest('window.open() is considered for slow click', async ({ getLocalTestUr // Ensure window.open() still works as expected const context = browser.contexts()[0]; - const [ reqResponse1 ] = await Promise.all([ + const [reqResponse1] = await Promise.all([ reqPromise1, context.waitForEvent('page'), page.locator('#windowOpenButton').click(), - ]) + ]); const { breadcrumbs } = getCustomRecordingEvents(reqResponse1);