From d1f46a1b27118279eb42df92c1c429b18ec2766a Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Fri, 26 Jan 2024 11:07:42 +0100 Subject: [PATCH 1/2] ref(browser-integration-tests): Fix flake in interaction transaction tests --- .../suites/tracing/browsertracing/interactions/test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-packages/browser-integration-tests/suites/tracing/browsertracing/interactions/test.ts b/dev-packages/browser-integration-tests/suites/tracing/browsertracing/interactions/test.ts index 131403756251..50c095dbcc57 100644 --- a/dev-packages/browser-integration-tests/suites/tracing/browsertracing/interactions/test.ts +++ b/dev-packages/browser-integration-tests/suites/tracing/browsertracing/interactions/test.ts @@ -51,7 +51,7 @@ sentryTest('should capture interaction transaction. @firefox', async ({ browserN expect(interactionSpan.timestamp).toBeDefined(); const interactionSpanDuration = (interactionSpan.timestamp! - interactionSpan.start_timestamp) * 1000; - expect(interactionSpanDuration).toBeGreaterThan(70); + expect(interactionSpanDuration).toBeGreaterThan(65); expect(interactionSpanDuration).toBeLessThan(200); }); From 780842cea113423c307aac9214cb153ac13b5d6b Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Fri, 26 Jan 2024 11:15:38 +0100 Subject: [PATCH 2/2] s/Event/SerializedEvent --- .../tracing/browsertracing/interactions/test.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/dev-packages/browser-integration-tests/suites/tracing/browsertracing/interactions/test.ts b/dev-packages/browser-integration-tests/suites/tracing/browsertracing/interactions/test.ts index 50c095dbcc57..fa9d2889bae3 100644 --- a/dev-packages/browser-integration-tests/suites/tracing/browsertracing/interactions/test.ts +++ b/dev-packages/browser-integration-tests/suites/tracing/browsertracing/interactions/test.ts @@ -1,6 +1,6 @@ import type { Route } from '@playwright/test'; import { expect } from '@playwright/test'; -import type { Event, Span, SpanContext, Transaction } from '@sentry/types'; +import type { SerializedEvent, Span, SpanContext, Transaction } from '@sentry/types'; import { sentryTest } from '../../../../utils/fixtures'; import { @@ -30,7 +30,7 @@ sentryTest('should capture interaction transaction. @firefox', async ({ browserN const url = await getLocalTestPath({ testDir: __dirname }); await page.goto(url); - await getFirstSentryEnvelopeRequest(page); + await getFirstSentryEnvelopeRequest(page); await page.locator('[data-test-id=interaction-button]').click(); await page.locator('.clicked[data-test-id=interaction-button]').isVisible(); @@ -70,12 +70,12 @@ sentryTest( const url = await getLocalTestPath({ testDir: __dirname }); await page.goto(url); - await getFirstSentryEnvelopeRequest(page); + await getFirstSentryEnvelopeRequest(page); for (let i = 0; i < 4; i++) { await wait(100); await page.locator('[data-test-id=interaction-button]').click(); - const envelope = await getMultipleSentryEnvelopeRequests(page, 1); + const envelope = await getMultipleSentryEnvelopeRequests(page, 1); expect(envelope[0].spans).toHaveLength(1); } }, @@ -97,11 +97,11 @@ sentryTest( const url = await getLocalTestPath({ testDir: __dirname }); await page.goto(url); - await getFirstSentryEnvelopeRequest(page); + await getFirstSentryEnvelopeRequest(page); await page.locator('[data-test-id=annotated-button]').click(); - const envelopes = await getMultipleSentryEnvelopeRequests(page, 1); + const envelopes = await getMultipleSentryEnvelopeRequests(page, 1); expect(envelopes).toHaveLength(1); const eventData = envelopes[0];