From bcec51d0222760df19eae171247ad903edf0ef11 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Wed, 10 Jan 2024 14:15:08 +0100 Subject: [PATCH] test(bun): Fix failing test after `span.isRecording` change --- packages/bun/test/integrations/bunserver.test.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/bun/test/integrations/bunserver.test.ts b/packages/bun/test/integrations/bunserver.test.ts index 6356300562ac..286d30749dc1 100644 --- a/packages/bun/test/integrations/bunserver.test.ts +++ b/packages/bun/test/integrations/bunserver.test.ts @@ -1,5 +1,5 @@ import { beforeAll, beforeEach, describe, expect, test } from 'bun:test'; -import { Hub, makeMain, spanToJSON } from '@sentry/core'; +import { Hub, getDynamicSamplingContextFromSpan, makeMain, spanIsSampled, spanToJSON } from '@sentry/core'; import { BunClient } from '../../src/client'; import { instrumentBunServe } from '../../src/integrations/bunserver'; @@ -82,10 +82,16 @@ describe('Bun Serve Integration', () => { client.on('finishTransaction', transaction => { expect(transaction.spanContext().traceId).toBe(TRACE_ID); expect(transaction.parentSpanId).toBe(PARENT_SPAN_ID); - expect(transaction.isRecording()).toBe(true); + expect(spanIsSampled(transaction)).toBe(true); + // span.endTimestamp is already set in `finishTransaction` hook + expect(transaction.isRecording()).toBe(false); // eslint-disable-next-line deprecation/deprecation expect(transaction.metadata?.dynamicSamplingContext).toStrictEqual({ version: '1.0', environment: 'production' }); + expect(getDynamicSamplingContextFromSpan(transaction)).toStrictEqual({ + version: '1.0', + environment: 'production', + }); }); const server = Bun.serve({