Dialog shows regardless of the ignoreErrors rules

[glung]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using? If you use the CDN bundles, please specify the exact bundle (e.g. bundle.tracing.min.js) in your SDK setup.

@sentry/angular

SDK Version

7.46.0

Framework Version

@sentry/angular

Link to Sentry event

No response

SDK Setup

Sentry init

      Sentry.init({
        dsn: '***',
        ignoreErrors: [
          'Error to ignore'
        ]
      })

Angular error handler:

createErrorHandler({
  showDialog: environment.production === false,
})

Steps to Reproduce

1. Setup Sentry and ignore error
2. Register the Sentry error handler with showDalog
3. Fire the ignore - that should be ignored

Expected Result

The error is not sent
The dialog does not show

Actual Result

The error is not sent
The dialog shows

[Lms24]

Hi @glung thanks for reporting! I can reproduce this locally and you're right, we should change this. Currently I'm thinking we can use our newly introduced internal SDK hooks (#7262) to only show the dialog once the event is actually sent.

I'll open a PR with a fix soon.

Note: We'll need to apply the same fix in the React SDK as well.

[glung]

Thx a lot @Lms24