Skip to content

Replay events should have a unique event_id #6649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lms24 opened this issue Jan 4, 2023 · 0 comments · Fixed by #6650
Closed

Replay events should have a unique event_id #6649

Lms24 opened this issue Jan 4, 2023 · 0 comments · Fixed by #6650
Assignees
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Improvement

Comments

@Lms24
Copy link
Member

Lms24 commented Jan 4, 2023

Problem Statement

Currently, we're assigning the replayId as event_id in each Replay event we send to Sentry. All events/segments of one Replay session, have therefore the same event_id. This works because we do not process Replay events in the same way as other events, which is why we don't strictly need unique event ids for each event. However, we should nevertheless change this as it could end up becoming problematic if we ever change something around Replay event processing. Furthermore, it's very confusing and an easy fix.

Solution Brainstorm

Assign a unique uuid4 event_id, just like we do with all other events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants