Skip to content

Remove hard cap from maxBreadcrumbs #4693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marandaneto opened this issue Mar 8, 2022 · 2 comments · Fixed by #5873
Closed

Remove hard cap from maxBreadcrumbs #4693

marandaneto opened this issue Mar 8, 2022 · 2 comments · Fixed by #5873

Comments

@marandaneto
Copy link

Problem Statement

maxBreadcrumbs is a configurable option, but it can't be set > 100 because of a hard cap.
This is the output after discussing #4682 with @HazAT

Solution Brainstorm

maxBreadcrumbs should be configurable, default to 100, but it can be set > 100 at your own risk.
I'd also add to the property docs about the max payload size for events (currently 1 MB).
Adjust the docs that made the confusion getsentry/sentry-docs#4496 and getsentry/sentry-docs#4794

@marandaneto
Copy link
Author

@Lms24 thanks.
Consider merging this once this version is released.

@Lms24
Copy link
Member

Lms24 commented Oct 5, 2022

@marandaneto thanks for the reminder. Will put it on my ToDos.
(All the credits for working on this go to @outsideris btw)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants