-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Track DOMException.name instead of DOMException.code #10501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey @behnam-oneschema, this is something we might do for our v8 version (#9508), adding it to our milestone! |
So taking another look at this - shouldn't |
Yeah, indeed it looks like |
@behnam-oneschema right. We are setting Having this as a tag makes very little sense, as all the errors that are grouped together likely have the same tag value. We should some sort of context instead probably. (Side-note: having @AbhiPrasad I think the TODO for us here is to move this into a context or data field. |
Problem Statement
DOMException.code
is a deprecated feature. Reference: https://developer.mozilla.org/en-US/docs/Web/API/DOMExceptionThe codes are also hardly practical, considering only the numeric value of them is shown in the Sentry UI:

Solution Brainstorm
DOMException.name is the current best-practice in identifying these errors, and is supported widely across browsers:
The text was updated successfully, but these errors were encountered: