fix(sveltekit): Fix <meta> tag injection (#7612)

Lms24 · web-flow · commit f6ce5c9bff6d · 2023-03-27T16:54:02.000+02:00
Apparently, the `%sveltekit.head%` placeholder isn't present in the html that's passed to `transformPageChunk`. Hence our `<meta>` tag injection logic introduced in #7574 didn't find the anchor point where to inject the tags. This PR fixes the injection, by simply appending it to an open `<head>` tag. It's not pretty but it should do the trick 🤞 (we can revisit if this breaks folks).
diff --git a/packages/sveltekit/src/server/handle.ts b/packages/sveltekit/src/server/handle.ts
@@ -40,10 +40,10 @@ export const transformPageChunk: NonNullable<ResolveOptions['transformPageChunk'
   if (transaction) {
     const traceparentData = transaction.toTraceparent();
     const dynamicSamplingContext = dynamicSamplingContextToSentryBaggageHeader(transaction.getDynamicSamplingContext());
-    const content = `<meta name="sentry-trace" content="${traceparentData}"/>
-      <meta name="baggage" content="${dynamicSamplingContext}"/>
-      %sveltekit.head%`;
-    return html.replace('%sveltekit.head%', content);
+    const content = `<head>
+      <meta name="sentry-trace" content="${traceparentData}"/>
+      <meta name="baggage" content="${dynamicSamplingContext}"/>`;
+    return html.replace('<head>', content);
   }
 
   return html;
diff --git a/packages/sveltekit/test/server/handle.test.ts b/packages/sveltekit/test/server/handle.test.ts
@@ -271,7 +271,6 @@ describe('transformPageChunk', () => {
       <meta charset="utf-8" />
       <link rel="icon" href="%sveltekit.assets%/favicon.png" />
       <meta name="viewport" content="width=device-width" />
-      %sveltekit.head%
     </head>
     <body data-sveltekit-preload-data="hover">
       <div style="display: contents">%sveltekit.body%</div>
