rename to handleErrorWithSentry

Author: AbhiPrasad

packages/sveltekit/src/client/handleError.ts

@@ -11,7 +11,7 @@ import type { HandleClientError, NavigationEvent } from '@sveltejs/kit';
  *
  * @param handleError The original SvelteKit error handler.
  */
-export function wrapHandleErrorWithSentry(handleError: HandleClientError): HandleClientError {
+export function handleErrorWithSentry(handleError?: HandleClientError): HandleClientError {
   return (input: { error: unknown; event: NavigationEvent }): ReturnType<HandleClientError> => {
     captureException(input.error, scope => {
       scope.addEventProcessor(event => {
@@ -23,6 +23,8 @@ export function wrapHandleErrorWithSentry(handleError: HandleClientError): Handl
       });
       return scope;
     });
-    return handleError(input);
+    if (handleError) {
+      return handleError(input);
+    }
   };
 }

packages/sveltekit/src/client/index.ts

@@ -1,7 +1,7 @@
 export * from '@sentry/svelte';
 
 export { init } from './sdk';
-export { wrapHandleErrorWithSentry } from './handleError';
+export { handleErrorWithSentry } from './handleError';
 
 // Just here so that eslint is happy until we export more stuff here
 export const PLACEHOLDER_CLIENT = 'PLACEHOLDER';

packages/sveltekit/src/index.types.ts

@@ -17,7 +17,7 @@ import type * as serverSdk from './server';
 /** Initializes Sentry SvelteKit SDK */
 export declare function init(options: Options | clientSdk.BrowserOptions | serverSdk.NodeOptions): void;
 
-export declare function wrapHandleErrorWithSentry<T extends HandleClientError | HandleServerError>(
+export declare function handleErrorWithSentry<T extends HandleClientError | HandleServerError>(
   handleError: T,
 ): ReturnType<T>;
 

packages/sveltekit/src/server/handleError.ts

@@ -11,7 +11,7 @@ import type { HandleServerError, RequestEvent } from '@sveltejs/kit';
  *
  * @param handleError The original SvelteKit error handler.
  */
-export function wrapHandleErrorWithSentry(handleError: HandleServerError): HandleServerError {
+export function handleErrorWithSentry(handleError?: HandleServerError): HandleServerError {
   return (input: { error: unknown; event: RequestEvent }): ReturnType<HandleServerError> => {
     captureException(input.error, scope => {
       scope.addEventProcessor(event => {
@@ -23,6 +23,8 @@ export function wrapHandleErrorWithSentry(handleError: HandleServerError): Handl
       });
       return scope;
     });
-    return handleError(input);
+    if (handleError) {
+      return handleError(input);
+    }
   };
 }

packages/sveltekit/src/server/index.ts

@@ -1,4 +1,4 @@
 export * from '@sentry/node';
 
 export { init } from './sdk';
-export { wrapHandleErrorWithSentry } from './handleError';
+export { handleErrorWithSentry } from './handleError';

packages/sveltekit/test/client/handleError.test.ts

@@ -55,6 +55,16 @@ describe('handleError', () => {
     mockScope = new Scope();
   });
 
+  it('works when a handleError func is not provided', async () => {
+    const wrappedHandleError = wrapHandleErrorWithSentry();
+    const mockError = new Error('test');
+    const returnVal = await wrappedHandleError({ error: mockError, event: navigationEvent });
+
+    expect(returnVal).not.toBeDefined();
+    expect(mockCaptureException).toHaveBeenCalledTimes(1);
+    expect(mockCaptureException).toHaveBeenCalledWith(mockError, expect.any(Function));
+  });
+
   it('calls captureException', async () => {
     const wrappedHandleError = wrapHandleErrorWithSentry(handleError);
     const mockError = new Error('test');

packages/sveltekit/test/server/handleError.test.ts

@@ -47,6 +47,16 @@ describe('handleError', () => {
     mockScope = new Scope();
   });
 
+  it('works when a handleError func is not provided', async () => {
+    const wrappedHandleError = wrapHandleErrorWithSentry();
+    const mockError = new Error('test');
+    const returnVal = await wrappedHandleError({ error: mockError, event: requestEvent });
+
+    expect(returnVal).not.toBeDefined();
+    expect(mockCaptureException).toHaveBeenCalledTimes(1);
+    expect(mockCaptureException).toHaveBeenCalledWith(mockError, expect.any(Function));
+  });
+
   it('calls captureException', async () => {
     const wrappedHandleError = wrapHandleErrorWithSentry(handleError);
     const mockError = new Error('test');