Skip to content

Commit e15885a

Browse files
authored
feat(meta-sdks): Remove runtime tags (#13105)
Runtime tags are already set by e.g. Relay, so the Meta-Framework SDKs do not need to set them anymore. Comment why this change was made: #13101 (review)
1 parent 7150e3f commit e15885a

File tree

37 files changed

+36
-223
lines changed

37 files changed

+36
-223
lines changed

dev-packages/e2e-tests/test-applications/create-next-app/tests/client-transactions.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ test('Sends a pageload transaction to Sentry', async ({ page }) => {
1313
expect(transactionEvent).toEqual(
1414
expect.objectContaining({
1515
transaction: '/',
16-
tags: { runtime: 'browser' },
1716
transaction_info: { source: 'route' },
1817
type: 'transaction',
1918
contexts: {
@@ -59,7 +58,6 @@ test('captures a navigation transcation to Sentry', async ({ page }) => {
5958
expect(clientTxnEvent).toEqual(
6059
expect.objectContaining({
6160
transaction: '/user/[id]',
62-
tags: { runtime: 'browser' },
6361
transaction_info: { source: 'route' },
6462
type: 'transaction',
6563
contexts: {

dev-packages/e2e-tests/test-applications/create-next-app/tests/server-transactions.test.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ test('Sends server-side transactions to Sentry', async ({ baseURL }) => {
3232
}),
3333
status: 'ok',
3434
},
35-
runtime: {
36-
name: 'node',
37-
version: expect.any(String),
38-
},
3935
}),
4036
spans: [
4137
{

dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/transactions.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ test('Sends a pageload transaction', async ({ page }) => {
1919
expect(transactionEvent).toEqual(
2020
expect.objectContaining({
2121
transaction: '/',
22-
tags: { runtime: 'browser' },
2322
transaction_info: { source: 'url' },
2423
type: 'transaction',
2524
contexts: {

dev-packages/e2e-tests/test-applications/solidstart/tests/errors.client.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ test.describe('client-side errors', () => {
2626
},
2727
transaction: '/client-error',
2828
});
29-
expect(error.tags).toMatchObject({ runtime: 'browser' });
3029
expect(error.transaction).toEqual('/client-error');
3130
});
3231
});

dev-packages/e2e-tests/test-applications/solidstart/tests/errors.server.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ test.describe('server-side errors', () => {
1111

1212
const error = await errorEventPromise;
1313

14-
expect(error.tags).toMatchObject({ runtime: 'node' });
1514
expect(error).toMatchObject({
1615
exception: {
1716
values: [

dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/errors.client.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ test.describe('client-side errors', () => {
2626
}),
2727
);
2828

29-
expect(errorEvent.tags).toMatchObject({ runtime: 'browser' });
30-
3129
expect(errorEvent.transaction).toEqual('/client-error');
3230
});
3331

@@ -53,7 +51,6 @@ test.describe('client-side errors', () => {
5351
}),
5452
);
5553

56-
expect(errorEvent.tags).toMatchObject({ runtime: 'browser' });
5754
expect(errorEvent.transaction).toEqual('/universal-load-error');
5855
});
5956
});

dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/errors.server.test.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ test.describe('server-side errors', () => {
1919
}),
2020
);
2121

22-
expect(errorEvent.tags).toMatchObject({ runtime: 'node' });
23-
2422
expect(errorEvent.request).toEqual({
2523
cookies: {},
2624
headers: expect.objectContaining({
@@ -49,8 +47,6 @@ test.describe('server-side errors', () => {
4947
}),
5048
);
5149

52-
expect(errorEvent.tags).toMatchObject({ runtime: 'node' });
53-
5450
expect(errorEvent.request).toEqual({
5551
cookies: {},
5652
headers: expect.objectContaining({

dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.server.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ test('server pageload request span has nested request span for sub request', asy
1313

1414
expect(serverTxnEvent).toMatchObject({
1515
transaction: 'GET /server-load-fetch',
16-
tags: { runtime: 'node' },
1716
transaction_info: { source: 'route' },
1817
type: 'transaction',
1918
contexts: {

dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.test.ts

Lines changed: 5 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ test.describe('performance events', () => {
2121

2222
expect(clientTxnEvent).toMatchObject({
2323
transaction: '/users/[id]',
24-
tags: { runtime: 'browser' },
2524
transaction_info: { source: 'route' },
2625
type: 'transaction',
2726
contexts: {
@@ -34,7 +33,6 @@ test.describe('performance events', () => {
3433

3534
expect(serverTxnEvent).toMatchObject({
3635
transaction: 'GET /users/[id]',
37-
tags: { runtime: 'node' },
3836
transaction_info: { source: 'route' },
3937
type: 'transaction',
4038
contexts: {
@@ -77,7 +75,6 @@ test.describe('performance events', () => {
7775

7876
expect(clientTxnEvent).toMatchObject({
7977
transaction: '/users',
80-
tags: { runtime: 'browser' },
8178
transaction_info: { source: 'route' },
8279
type: 'transaction',
8380
contexts: {
@@ -90,7 +87,6 @@ test.describe('performance events', () => {
9087

9188
expect(serverTxnEvent).toMatchObject({
9289
transaction: 'GET /users',
93-
tags: { runtime: 'node' },
9490
transaction_info: { source: 'route' },
9591
type: 'transaction',
9692
contexts: {
@@ -130,7 +126,6 @@ test.describe('performance events', () => {
130126

131127
expect(clientTxnEvent).toMatchObject({
132128
transaction: '/universal-load-fetch',
133-
tags: { runtime: 'browser' },
134129
transaction_info: { source: 'route' },
135130
type: 'transaction',
136131
contexts: {
@@ -143,7 +138,6 @@ test.describe('performance events', () => {
143138

144139
expect(serverTxnEvent).toMatchObject({
145140
transaction: 'GET /api/users',
146-
tags: { runtime: 'node' },
147141
transaction_info: { source: 'route' },
148142
type: 'transaction',
149143
contexts: {
@@ -186,11 +180,11 @@ test.describe('performance events', () => {
186180

187181
test('captures a navigation transaction directly after pageload', async ({ page }) => {
188182
const clientPageloadTxnPromise = waitForTransaction('sveltekit-2-svelte-5', txnEvent => {
189-
return txnEvent?.contexts?.trace?.op === 'pageload' && txnEvent?.tags?.runtime === 'browser';
183+
return txnEvent?.contexts?.trace?.op === 'pageload';
190184
});
191185

192186
const clientNavigationTxnPromise = waitForTransaction('sveltekit-2-svelte-5', txnEvent => {
193-
return txnEvent?.contexts?.trace?.op === 'navigation' && txnEvent?.tags?.runtime === 'browser';
187+
return txnEvent?.contexts?.trace?.op === 'navigation';
194188
});
195189

196190
await waitForInitialPageload(page, { route: '/' });
@@ -205,7 +199,6 @@ test.describe('performance events', () => {
205199

206200
expect(pageloadTxnEvent).toMatchObject({
207201
transaction: '/',
208-
tags: { runtime: 'browser' },
209202
transaction_info: { source: 'route' },
210203
type: 'transaction',
211204
contexts: {
@@ -218,7 +211,6 @@ test.describe('performance events', () => {
218211

219212
expect(navigationTxnEvent).toMatchObject({
220213
transaction: '/users/[id]',
221-
tags: { runtime: 'browser' },
222214
transaction_info: { source: 'route' },
223215
type: 'transaction',
224216
contexts: {
@@ -253,27 +245,15 @@ test.describe('performance events', () => {
253245

254246
test('captures one navigation transaction per redirect', async ({ page }) => {
255247
const clientNavigationRedirect1TxnPromise = waitForTransaction('sveltekit-2-svelte-5', txnEvent => {
256-
return (
257-
txnEvent?.contexts?.trace?.op === 'navigation' &&
258-
txnEvent?.tags?.runtime === 'browser' &&
259-
txnEvent?.transaction === '/redirect1'
260-
);
248+
return txnEvent?.contexts?.trace?.op === 'navigation' && txnEvent?.transaction === '/redirect1';
261249
});
262250

263251
const clientNavigationRedirect2TxnPromise = waitForTransaction('sveltekit-2-svelte-5', txnEvent => {
264-
return (
265-
txnEvent?.contexts?.trace?.op === 'navigation' &&
266-
txnEvent?.tags?.runtime === 'browser' &&
267-
txnEvent?.transaction === '/redirect2'
268-
);
252+
return txnEvent?.contexts?.trace?.op === 'navigation' && txnEvent?.transaction === '/redirect2';
269253
});
270254

271255
const clientNavigationRedirect3TxnPromise = waitForTransaction('sveltekit-2-svelte-5', txnEvent => {
272-
return (
273-
txnEvent?.contexts?.trace?.op === 'navigation' &&
274-
txnEvent?.tags?.runtime === 'browser' &&
275-
txnEvent?.transaction === '/users/[id]'
276-
);
256+
return txnEvent?.contexts?.trace?.op === 'navigation' && txnEvent?.transaction === '/users/[id]';
277257
});
278258

279259
await waitForInitialPageload(page, { route: '/' });
@@ -289,7 +269,6 @@ test.describe('performance events', () => {
289269

290270
expect(redirect1TxnEvent).toMatchObject({
291271
transaction: '/redirect1',
292-
tags: { runtime: 'browser' },
293272
transaction_info: { source: 'route' },
294273
type: 'transaction',
295274
contexts: {
@@ -327,7 +306,6 @@ test.describe('performance events', () => {
327306

328307
expect(redirect2TxnEvent).toMatchObject({
329308
transaction: '/redirect2',
330-
tags: { runtime: 'browser' },
331309
transaction_info: { source: 'route' },
332310
type: 'transaction',
333311
contexts: {
@@ -365,7 +343,6 @@ test.describe('performance events', () => {
365343

366344
expect(redirect3TxnEvent).toMatchObject({
367345
transaction: '/users/[id]',
368-
tags: { runtime: 'browser' },
369346
transaction_info: { source: 'route' },
370347
type: 'transaction',
371348
contexts: {

dev-packages/e2e-tests/test-applications/sveltekit-2/tests/errors.client.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ test.describe('client-side errors', () => {
2626
}),
2727
);
2828

29-
expect(errorEvent.tags).toMatchObject({ runtime: 'browser' });
30-
3129
expect(errorEvent.transaction).toEqual('/client-error');
3230
});
3331

@@ -53,7 +51,6 @@ test.describe('client-side errors', () => {
5351
}),
5452
);
5553

56-
expect(errorEvent.tags).toMatchObject({ runtime: 'browser' });
5754
expect(errorEvent.transaction).toEqual('/universal-load-error');
5855
});
5956
});

dev-packages/e2e-tests/test-applications/sveltekit-2/tests/errors.server.test.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ test.describe('server-side errors', () => {
1818
in_app: true,
1919
}),
2020
);
21-
22-
expect(errorEvent.tags).toMatchObject({ runtime: 'node' });
2321
});
2422

2523
test('captures server load error', async ({ page }) => {
@@ -38,8 +36,6 @@ test.describe('server-side errors', () => {
3836
in_app: true,
3937
}),
4038
);
41-
42-
expect(errorEvent.tags).toMatchObject({ runtime: 'node' });
4339
});
4440

4541
test('captures server route (GET) error', async ({ page }) => {

dev-packages/e2e-tests/test-applications/sveltekit-2/tests/performance.server.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ test('server pageload request span has nested request span for sub request', asy
1313

1414
expect(serverTxnEvent).toMatchObject({
1515
transaction: 'GET /server-load-fetch',
16-
tags: { runtime: 'node' },
1716
transaction_info: { source: 'route' },
1817
type: 'transaction',
1918
contexts: {

0 commit comments

Comments
 (0)