fix dangerfile

Author: AbhiPrasad

.eslintrc.js

@@ -24,9 +24,6 @@ module.exports = {
         project: './tsconfig.json',
       },
       rules: {
-        // We want to prevent async await usage in our files to prevent uncessary bundle size. Turned off in tests.
-        'sentry-sdk/no-async-await': 'error',
-
         // Unused variables should be removed unless they are marked with and underscore (ex. _varName).
         '@typescript-eslint/no-unused-vars': ['warn', { argsIgnorePattern: '^_' }],
 
@@ -71,6 +68,14 @@ module.exports = {
             leadingUnderscore: 'require',
           },
         ],
+      },
+    },
+    {
+      // Configuration for files under src
+      files: ['src/**/*'],
+      rules: {
+        // We want to prevent async await usage in our files to prevent uncessary bundle size.
+        'sentry-sdk/no-async-await': 'error',
 
         // JSDOC comments are required for classes and methods. As we have a public facing codebase, documentation,
         // even if it may seems excessive at times, is important to emphasize. Turned off in tests.
@@ -87,8 +92,6 @@ module.exports = {
       },
       files: ['*.test.ts', '*.test.tsx', '*.test.js', '*.test.jsx'],
       rules: {
-        'sentry-sdk/no-async-await': 'off',
-        'jsdoc/require-jsdoc': 'off',
         'max-lines': 'off',
       },
     },

CHANGELOG.md

@@ -5,6 +5,7 @@
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 - [ember] feat: Add `@sentry/ember` (#2739)
 - [apm/tracing] fix: Mark side effects for tracing hub extensions (#2788)
+- [browser] ref: Use stronger function return typings (#2786)
 
 ## 5.20.1
 

dangerfile.ts

@@ -12,15 +12,16 @@ const packages = ['apm', 'core', 'hub', 'integrations', 'minimal', 'node', 'type
  * Eslint your code with Danger
  * Based on fork from: https://github.com/appcelerator/danger-plugin-eslint
  */
-async function eslint() {
+async function eslint(): Promise<void[]> {
   const allFiles = danger.git.created_files.concat(danger.git.modified_files);
   const cli = new CLIEngine({});
   // let eslint filter down to non-ignored, matching the extensions expected
   const filesToLint = allFiles.filter(f => !cli.isPathIgnored(f));
   return Promise.all(filesToLint.map(f => lintFile(cli, f)));
 }
 
-async function lintFile(linter: CLIEngine, path: string) {
+/** JSDoc */
+async function lintFile(linter: CLIEngine, path: string): Promise<void> {
   const contents = await danger.github.utils.fileContents(path);
   const report = linter.executeOnText(contents, path);
 
@@ -31,15 +32,15 @@ async function lintFile(linter: CLIEngine, path: string) {
         return;
       }
 
-      const noop = () => {};
+      const noop = (): void => undefined;
       const fn = { 0: noop, 1: warn, 2: fail }[msg.severity];
 
       fn(`${path} line ${msg.line} – ${msg.message} (${msg.ruleId})`, path, msg.line);
     });
   }
 }
 
-export default async () => {
+export default async (): Promise<void> => {
   if (!danger.github) {
     return;
   }

yarn.lock

@@ -3287,32 +3287,11 @@ [email protected]:
   resolved "https://registry.yarnpkg.com/after/-/after-0.8.2.tgz#fedb394f9f0e02aa9768e702bda23b505fae7e1f"
   integrity sha1-/ts5T58OAqqXaOcCvaI7UF+ufh8=
 
-agent-base@4, agent-base@^4.3.0:
-  version "4.3.0"
-  resolved "https://registry.yarnpkg.com/agent-base/-/agent-base-4.3.0.tgz#8165f01c436009bccad0b1d122f05ed770efc6ee"
-  integrity sha512-salcGninV0nPrwpGNn4VTXBb1SOuXQBiqbrNXoeizJsHrsL6ERFM2Ne3JUSBWRE6aeNJI2ROP/WEEIDUiDe3cg==
-  dependencies:
-    es6-promisify "^5.0.0"
-
-agent-base@5:
+agent-base@4, agent-base@5, agent-base@6, agent-base@^4.3.0, agent-base@~4.2.1:
   version "5.1.1"
   resolved "https://registry.yarnpkg.com/agent-base/-/agent-base-5.1.1.tgz#e8fb3f242959db44d63be665db7a8e739537a32c"
   integrity sha512-TMeqbNl2fMW0nMjTEPOwe3J/PRFP4vqeoNuQMG0HlMrtm5QxKqdvAkZ1pRBQ/ulIyDD5Yq0nJ7YbdD8ey0TO3g==
 
-agent-base@6:
-  version "6.0.1"
-  resolved "https://registry.yarnpkg.com/agent-base/-/agent-base-6.0.1.tgz#808007e4e5867decb0ab6ab2f928fbdb5a596db4"
-  integrity sha512-01q25QQDwLSsyfhrKbn8yuur+JNw0H+0Y4JiGIKd3z9aYk/w/2kxD/Upc+t2ZBBSUNff50VjPsSW2YxM8QYKVg==
-  dependencies:
-    debug "4"
-
-agent-base@~4.2.1:
-  version "4.2.1"
-  resolved "https://registry.yarnpkg.com/agent-base/-/agent-base-4.2.1.tgz#d89e5999f797875674c07d87f260fc41e83e8ca9"
-  integrity sha512-JVwXMr9nHYTUXsBFKUqhJwvlcYU/blreOEUkhNR2eXZIvwd+c+o5V4MgDPKWnMS/56awN3TRzIP+KoPn+roQtg==
-  dependencies:
-    es6-promisify "^5.0.0"
-
 agentkeepalive@^3.4.1:
   version "3.5.2"
   resolved "https://registry.yarnpkg.com/agentkeepalive/-/agentkeepalive-3.5.2.tgz#a113924dd3fa24a0bc3b78108c450c2abee00f67"
@@ -8531,18 +8510,6 @@ es6-object-assign@^1.1.0:
   resolved "https://registry.yarnpkg.com/es6-object-assign/-/es6-object-assign-1.1.0.tgz#c2c3582656247c39ea107cb1e6652b6f9f24523c"
   integrity sha1-wsNYJlYkfDnqEHyx5mUrb58kUjw=
 
-es6-promise@^4.0.3:
-  version "4.2.8"
-  resolved "https://registry.yarnpkg.com/es6-promise/-/es6-promise-4.2.8.tgz#4eb21594c972bc40553d276e510539143db53e0a"
-  integrity sha512-HJDGx5daxeIvxdBxvG2cb9g4tEvwIk3i8+nhX0yGrYmZUzbkdg8QbDevheDB8gd0//uPj4c1EQua8Q+MViT0/w==
-
-es6-promisify@^5.0.0:
-  version "5.0.0"
-  resolved "https://registry.yarnpkg.com/es6-promisify/-/es6-promisify-5.0.0.tgz#5109d62f3e56ea967c4b63505aef08291c8a5203"
-  integrity sha1-UQnWLz5W6pZ8S2NQWu8IKRyKUgM=
-  dependencies:
-    es6-promise "^4.0.3"
-
 escalade@^3.0.1:
   version "3.0.2"
   resolved "https://registry.yarnpkg.com/escalade/-/escalade-3.0.2.tgz#6a580d70edb87880f22b4c91d0d56078df6962c4"