with eslint danger

Author: AbhiPrasad

.eslintrc.js

@@ -20,9 +20,6 @@ module.exports = {
       extends: ['plugin:@typescript-eslint/recommended', 'prettier/@typescript-eslint'],
       plugins: ['@typescript-eslint'],
       parser: '@typescript-eslint/parser',
-      parserOptions: {
-        project: './tsconfig.json',
-      },
       rules: {
         // We want to prevent async await usage in our files to prevent uncessary bundle size. Turned off in tests.
         'sentry-sdk/no-async-await': 'error',

dangerfile.ts

@@ -4,32 +4,76 @@ import { promisify } from 'util';
 import { resolve } from 'path';
 import tslint from 'danger-plugin-tslint';
 import { prettyResults } from 'danger-plugin-tslint/dist/prettyResults';
+import { CLIEngine } from 'eslint';
 
-const packages = ['apm', 'browser', 'core', 'hub', 'integrations', 'minimal', 'node', 'types', 'utils'];
+interface Options {
+  baseConfig?: any;
+  extensions?: string[];
+}
+
+const packages = ['apm', 'core', 'hub', 'integrations', 'minimal', 'node', 'types', 'utils'];
+
+/**
+ * Eslint your code with Danger
+ * Based on fork from: https://github.com/appcelerator/danger-plugin-eslint
+ */
+async function eslint(config: any, extensions?: string[]) {
+  const allFiles = danger.git.created_files.concat(danger.git.modified_files);
+  const options: Options = { baseConfig: config };
+  if (extensions) {
+    options.extensions = extensions;
+  }
+  const cli = new CLIEngine(options);
+  // let eslint filter down to non-ignored, matching the extensions expected
+  const filesToLint = allFiles.filter(f => {
+    return !cli.isPathIgnored(f) && cli.options.extensions.some(ext => f.endsWith(ext));
+  });
+  return Promise.all(filesToLint.map(f => lintFile(cli, config, f)));
+}
+
+async function lintFile(linter, config, path) {
+  const contents = await danger.github.utils.fileContents(path);
+  const report = linter.executeOnText(contents, path);
+
+  if (report.results.length !== 0) {
+    report.results[0].messages.map(msg => {
+      if (msg.fatal) {
+        fail(`Fatal error linting ${path} with eslint.`);
+        return;
+      }
+
+      const fn = { 1: warn, 2: fail }[msg.severity];
+
+      fn(`${path} line ${msg.line} – ${msg.message} (${msg.ruleId})`, path, msg.line);
+    });
+  }
+}
 
 export default async () => {
   if (!danger.github) {
     return;
   }
 
   schedule(async () => {
-    const tsLintResult = (await Promise.all(
-      packages.map(packageName => {
-        return new Promise<string>(res => {
-          tslint({
-            lintResultsJsonPath: resolve(__dirname, 'packages', packageName, 'lint-results.json'),
-            handleResults: results => {
-              if (results.length > 0) {
-                const formattedResults = prettyResults(results);
-                res(`TSLint failed: **@sentry/${packageName}**\n\n${formattedResults}`);
-              } else {
-                res('');
-              }
-            },
+    const tsLintResult = (
+      await Promise.all(
+        packages.map(packageName => {
+          return new Promise<string>(res => {
+            tslint({
+              lintResultsJsonPath: resolve(__dirname, 'packages', packageName, 'lint-results.json'),
+              handleResults: results => {
+                if (results.length > 0) {
+                  const formattedResults = prettyResults(results);
+                  res(`TSLint failed: **@sentry/${packageName}**\n\n${formattedResults}`);
+                } else {
+                  res('');
+                }
+              },
+            });
           });
-        });
-      }),
-    )).filter(str => str.length);
+        }),
+      )
+    ).filter(str => str.length);
     if (tsLintResult.length) {
       tsLintResult.forEach(tsLintFail => {
         fail(`${tsLintFail}`);
@@ -39,6 +83,8 @@ export default async () => {
     }
   });
 
+  await eslint();
+
   const hasChangelog = danger.git.modified_files.indexOf('CHANGELOG.md') !== -1;
   const isTrivial = (danger.github.pr.body + danger.github.pr.title).includes('#trivial');
 

package.json

@@ -48,6 +48,7 @@
     "chai": "^4.1.2",
     "codecov": "^3.6.5",
     "danger": "^7.1.3",
+    "danger-plugin-eslint": "^0.1.0",
     "danger-plugin-tslint": "^2.0.0",
     "eslint": "^7.5.0",
     "eslint-config-prettier": "^6.11.0",

packages/browser/package.json

@@ -22,6 +22,7 @@
     "tslib": "^1.9.3"
   },
   "devDependencies": {
+    "@types/eslint": "^7.2.0",
     "@types/md5": "2.1.33",
     "btoa": "^1.2.1",
     "chai": "^4.1.2",

packages/browser/src/backend.ts

@@ -31,6 +31,11 @@ export interface BrowserOptions extends Options {
   blacklistUrls?: Array<string | RegExp>;
 }
 
+const lol = async () => {
+  await new Promise();
+  return 'hello';
+};
+
 /**
  * The Sentry Browser SDK Backend.
  * @hidden