Skip to content

Commit bd399b3

Browse files
committed
ref: Add todo note
1 parent db525cf commit bd399b3

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

packages/types/src/client.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,8 @@ export interface Client<O extends ClientOptions = ClientOptions> {
113113
* This can be used to e.g. lazy load integrations.
114114
* In most cases, this should not be necessary, and you're better off just passing the integrations via `integrations: []` at initialization time.
115115
* However, if you find the need to conditionally load & add an integration, you can use `addIntegration` to do so.
116+
*
117+
* TODO (v8): Make this a required method.
116118
* */
117119
addIntegration?(integration: Integration): void;
118120

packages/types/src/options.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ export interface ClientOptions<TO extends BaseTransportOptions = BaseTransportOp
222222
*/
223223
tracesSampler?: (samplingContext: SamplingContext) => number | boolean;
224224

225-
// TODO v8: Narrow the response type to `ErrorEvent` - this is technically a breaking change.
225+
// TODO (v8): Narrow the response type to `ErrorEvent` - this is technically a breaking change.
226226
/**
227227
* An event-processing callback for error and message events, guaranteed to be invoked after all other event
228228
* processors, which allows an event to be modified or dropped.
@@ -236,7 +236,7 @@ export interface ClientOptions<TO extends BaseTransportOptions = BaseTransportOp
236236
*/
237237
beforeSend?: (event: ErrorEvent, hint: EventHint) => PromiseLike<Event | null> | Event | null;
238238

239-
// TODO v8: Narrow the response type to `TransactionEvent` - this is technically a breaking change.
239+
// TODO (v8): Narrow the response type to `TransactionEvent` - this is technically a breaking change.
240240
/**
241241
* An event-processing callback for transaction events, guaranteed to be invoked after all other event
242242
* processors. This allows an event to be modified or dropped before it's sent.

0 commit comments

Comments
 (0)