add hooks types and base implementation

Author: AbhiPrasad

packages/core/src/baseclient.ts

@@ -9,6 +9,9 @@ import type {
   Event,
   EventDropReason,
   EventHint,
+  HookCallback,
+  HookName,
+  HookStore,
   Integration,
   IntegrationClass,
   Outcome,
@@ -97,7 +100,7 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
   /** Holds flushable  */
   private _outcomes: { [key: string]: number } = {};
 
-  private _hooks: Record<> = {};
+  private _hooks: HookStore = {};
 
   /**
    * Initializes this client instance.
@@ -353,7 +356,29 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
     }
   }
 
-  public on(): () => void {}
+  /**
+   * @inheritDoc
+   */
+  public on(hook: HookName, callback: HookCallback): void {
+    if (this._hooks[hook]) {
+      // @ts-ignore we cannot enforce the callback to match the hook
+      // while saving bundle size
+      this._hooks[hook].push(callback);
+    } else {
+      this._hooks[hook] = [];
+    }
+  }
+
+  /**
+   * @inheritDoc
+   */
+  public emit(hook: HookName, ...args: Parameters<HookCallback>): void {
+    if (this._hooks[hook]) {
+      // @ts-ignore we cannot enforce the callback to match the hook
+      // while saving bundle size
+      this._hooks[hook].forEach((callback: HookCallback) => callback(...args));
+    }
+  }
 
   /** Updates existing session based on the provided event */
   protected _updateSessionFromEvent(session: Session, event: Event): void {

packages/types/src/client.ts

@@ -2,13 +2,13 @@ import type { EventDropReason } from './clientreport';
 import type { DataCategory } from './datacategory';
 import type { DsnComponents } from './dsn';
 import type { Event, EventHint } from './event';
+import type { EnvelopeHookCallback, EnvelopeHookName, TransactionHookCallback, TransactionHookName } from './hooks';
 import type { Integration, IntegrationClass } from './integration';
 import type { ClientOptions } from './options';
 import type { Scope } from './scope';
 import type { SdkMetadata } from './sdkmetadata';
 import type { Session, SessionAggregates } from './session';
 import type { Severity, SeverityLevel } from './severity';
-import type { Transaction } from './transaction';
 import type { Transport } from './transport';
 
 /**
@@ -151,10 +151,25 @@ export interface Client<O extends ClientOptions = ClientOptions> {
 
   // HOOKS
 
-  on(
-    hook: 'startTransaction' | 'transactionFinish',
-    callback: (transaction: Transaction) => Transaction | null,
-  ): () => void;
+  /**
+   * Register a callback for transaction start and finish.
+   */
+  on(hook: TransactionHookName, callback: TransactionHookCallback): void;
+
+  /**
+   * Register a callback for envelope creation and sending.
+   */
+  on(hook: EnvelopeHookName, callback: EnvelopeHookCallback): void;
 
-  emit(hook: Hooks, ...params: unknown[]): void;
+  /**
+   * Fire a hook event for transaction start and finish. Expects to be given a transaction as the
+   * second argument.
+   */
+  emit(hook: TransactionHookName, ...params: Parameters<TransactionHookCallback>): void;
+
+  /*
+   * Fire a hook event for envelope creation and sending. Expects to be given an envelope as the
+   * second argument.
+   */
+  emit(hook: EnvelopeHookName, ...params: Parameters<EnvelopeHookCallback>): void;
 }

packages/types/src/hooks.ts

@@ -1 +1,19 @@
-export type Hooks = 'startTransaction' | 'transactionFinish';
+import type { Envelope } from './envelope';
+import type { Transaction } from './transaction';
+
+export type TransactionHookName = 'startTransaction' | 'transactionFinish';
+export type TransactionHookCallback = (transaction: Transaction) => void;
+
+export type EnvelopeHookName = 'beforeEnvelope';
+export type EnvelopeHookCallback = (envelope: Envelope) => void;
+
+export type HookName = TransactionHookName | EnvelopeHookName;
+export type HookCallback = TransactionHookCallback | EnvelopeHookCallback;
+
+export type HookStoreItem<N extends HookName, C extends HookCallback> = Partial<{ [key in N]: C[] }>;
+
+export type HookStore =
+  // Hooks related to transaction start/finish
+  HookStoreItem<TransactionHookName, TransactionHookCallback> &
+    // Hooks related to envelope create and send
+    HookStoreItem<EnvelopeHookName, EnvelopeHookCallback>;

packages/types/src/index.ts

@@ -96,4 +96,4 @@ export type { WrappedFunction } from './wrappedfunction';
 export type { Instrumenter } from './instrumenter';
 
 export type { BrowserClientReplayOptions } from './browseroptions';
-export type { Hooks } from './hooks';
+export type { HookStore, HookName, HookCallback } from './hooks';