Skip to content

Commit b08642e

Browse files
committed
fix tests
1 parent baf780f commit b08642e

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

packages/remix/src/utils/instrumentServer.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,14 +70,15 @@ function extractData(response: Response): Promise<unknown> {
7070
return responseClone.text();
7171
}
7272

73-
function captureRemixServerException(err: Error, name: string): void {
73+
function captureRemixServerException(err: Error, name: string, request: Request): void {
7474
// Skip capturing if the thrown error is not a 5xx response
7575
// https://remix.run/docs/en/v1/api/conventions#throwing-responses-in-loaders
7676
if (isResponse(err) && err.status < 500) {
7777
return;
7878
}
7979

8080
captureException(isResponse(err) ? extractData(err) : err, scope => {
81+
scope.setSDKProcessingMetadata({ request });
8182
scope.addEventProcessor(event => {
8283
addExceptionMechanism(event, {
8384
type: 'instrument',
@@ -127,7 +128,7 @@ function makeWrappedDocumentRequestFunction(
127128

128129
span?.finish();
129130
} catch (err) {
130-
captureRemixServerException(err, 'documentRequest');
131+
captureRemixServerException(err, 'documentRequest', request);
131132
throw err;
132133
}
133134

@@ -164,7 +165,7 @@ function makeWrappedDataFunction(origFn: DataFunction, id: string, name: 'action
164165
currentScope.setSpan(activeTransaction);
165166
span?.finish();
166167
} catch (err) {
167-
captureRemixServerException(err, name);
168+
captureRemixServerException(err, name, args.request);
168169
throw err;
169170
}
170171

packages/remix/src/utils/serverAdapters/express.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,11 @@ function wrapExpressRequestHandler(
6060
const request = extractRequestData(req);
6161
const hub = getCurrentHub();
6262
const options = hub.getClient()?.getOptions();
63+
const scope = hub.getScope();
64+
65+
if (scope) {
66+
scope.setSDKProcessingMetadata({ request });
67+
}
6368

6469
if (!options || !hasTracingEnabled(options) || !request.url || !request.method) {
6570
return origRequestHandler.call(this, req, res, next);

0 commit comments

Comments
 (0)