Skip to content

Commit 8d0ef2f

Browse files
author
Luca Forstner
committed
test(nextjs): Move playwright deps installation into CI pipeline
1 parent 8b3a576 commit 8d0ef2f

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -490,6 +490,7 @@ jobs:
490490
NODE_VERSION: ${{ matrix.node }}
491491
run: |
492492
cd packages/nextjs
493+
yarn playwright install-deps
493494
yarn test:integration
494495
495496
# Ember tests are separate from the rest because they are the slowest part of the test suite, and making them a

packages/nextjs/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,9 @@
6868
"test:build": "yarn ts-node test/buildProcess/runTest.ts",
6969
"test:unit": "jest",
7070
"test:integration": "./test/run-integration-tests.sh && yarn test:types",
71-
"test:integration:ci": "run-s test:integration:clean test:integration:client:ci test:integration:server",
7271
"test:integration:prepare": "(cd test/integration && yarn build && yarn start)",
7372
"test:integration:clean": "(cd test/integration && rimraf .cache node_modules build)",
74-
"test:integration:client": "yarn playwright install-deps && yarn playwright test test/integration/test/client/",
73+
"test:integration:client": "yarn playwright test test/integration/test/client/",
7574
"test:integration:client:ci": "yarn test:integration:client --browser='all' --reporter='line'",
7675
"test:integration:server": "export NODE_OPTIONS='--stack-trace-limit=25' && jest --config=test/integration/jest.config.js test/integration/test/server/",
7776
"test:types": "cd test/types && yarn test",

packages/nextjs/playwright.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import type { PlaywrightTestConfig } from '@playwright/test';
22

33
const config: PlaywrightTestConfig = {
4-
retries: 2,
4+
retries: 0, // We do not accept flakes.
55
timeout: 12000,
66
use: {
77
baseURL: 'http://localhost:3000',

0 commit comments

Comments
 (0)