apply modifications from review, minor stylistic changes

Author: Lms24

packages/browser/package.json

@@ -44,7 +44,7 @@
     "webpack": "^4.30.0"
   },
   "scripts": {
-    "build": "run-p build:cjs build:esm build:bundle && sh ../../scripts/postbuild.sh",
+    "build": "run-p build:cjs build:esm build:bundle && bash ../../scripts/postbuild.sh",
     "build:bundle": "rollup --config",
     "build:cjs": "tsc -p tsconfig.cjs.json",
     "build:dev": "run-p build:cjs build:esm",

rollup.config.js

@@ -257,6 +257,3 @@ export function makeConfigVariants(baseConfig) {
 
   return configVariants;
 }
-
-export const BUILD_DIR = 'build';
-export const BUNDLES_DIR = 'bundles';

scripts/postbuild.sh

@@ -6,9 +6,6 @@
 # in the copied package.json so that they align with the directory structure inside `build`.
 
 BUILD_DIR=build
-CJS_DIR=dist
-ESM_DIR=esm
-TYPES_DIR=types
 
 ASSETS="README.md
 LICENSE
@@ -27,16 +24,16 @@ for f in $ASSETS; do
 done
 
 # TEMPORARY (TODO remove in v7) copy types to esm and dist
-cp -r $BUILD_DIR/$TYPES_DIR/ $BUILD_DIR/$CJS_DIR
-cp -r $BUILD_DIR/$TYPES_DIR/ $BUILD_DIR/$ESM_DIR
+cp -r $BUILD_DIR/types/ $BUILD_DIR/dist
+cp -r $BUILD_DIR/types/ $BUILD_DIR/esm
 
 # package.json modifications
 
 # sed command to modify package.json entry points in build dir
 # remove `BUILD_DIR` from `main`, `module` and `type` entry point paths
 entryPointsCommand="/\"(main|module|types)\": .*,/s/$BUILD_DIR\///"
 
-# modify volta extends path
+# sed command to modify volta extends path
 # remove one `../` from the extension path of volta
 voltaExtendsCommand="/\"extends\": \"\.\.\/\.\.\/\.\.\/package.json\"/s/\.\.\/\.\.\/\.\.\//\.\.\/\.\.\//"