Skip to content

Commit 67c3b6a

Browse files
authored
test(e2e): Use latest || * instead of * as version (#8585)
Due to the [way pnpm handles versions](pnpm/pnpm#6463), the version `*` we use in E2E tests is actually incorrect, because it installs the _lowest_ version it can find, e.g. 0.1.0. This is usually not a problem as when we use verdaccio, there is only a single version in the repository. however, when running things locally/debugging stuff, and you run `pnpm install` without verdaccio, stuff fails. This updates the versions used in E2E tests to `latest || *`, which results in a correct resolution.
1 parent 07e2e43 commit 67c3b6a

File tree

13 files changed

+24
-23
lines changed

13 files changed

+24
-23
lines changed

packages/e2e-tests/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ fields:
7979
**An important thing to note:** In the context of the `buildCommand` the fake test registry is available at
8080
`http://localhost:4873`. It hosts all of our packages as if they were to be published with the state of the current
8181
branch. This means we can install the packages from this registry via the `.npmrc` configuration as seen above. If you
82-
add Sentry dependencies to your test application, you should set the dependency versions set to `*`:
82+
add Sentry dependencies to your test application, you should set the dependency versions set to `latest || *` in order
83+
for it to work with both regular and prerelease versions:
8384

8485
```jsonc
8586
// package.json
@@ -91,7 +92,7 @@ add Sentry dependencies to your test application, you should set the dependency
9192
"test": "echo \"Hello world!\""
9293
},
9394
"dependencies": {
94-
"@sentry/node": "*"
95+
"@sentry/node": "latest || *"
9596
}
9697
}
9798
```

packages/e2e-tests/test-applications/create-next-app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
},
1010
"dependencies": {
1111
"@next/font": "13.0.7",
12-
"@sentry/nextjs": "*",
12+
"@sentry/nextjs": "latest || *",
1313
"@types/node": "18.11.17",
1414
"@types/react": "18.0.26",
1515
"@types/react-dom": "18.0.9",

packages/e2e-tests/test-applications/create-react-app/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
"version": "0.1.0",
44
"private": true,
55
"dependencies": {
6-
"@sentry/react": "*",
7-
"@sentry/tracing": "*",
6+
"@sentry/react": "latest || *",
7+
"@sentry/tracing": "latest || *",
88
"@testing-library/jest-dom": "5.14.1",
99
"@testing-library/react": "13.0.0",
1010
"@testing-library/user-event": "13.2.1",

packages/e2e-tests/test-applications/create-remix-app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"typecheck": "tsc"
99
},
1010
"dependencies": {
11-
"@sentry/remix": "*",
11+
"@sentry/remix": "latest || *",
1212
"@remix-run/css-bundle": "^1.16.1",
1313
"@remix-run/node": "^1.16.1",
1414
"@remix-run/react": "^1.16.1",

packages/e2e-tests/test-applications/nextjs-app-dir/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
},
1010
"dependencies": {
1111
"@next/font": "13.0.7",
12-
"@sentry/nextjs": "*",
12+
"@sentry/nextjs": "latest || *",
1313
"@types/node": "18.11.17",
1414
"@types/react": "18.0.26",
1515
"@types/react-dom": "18.0.9",

packages/e2e-tests/test-applications/nextjs-app-dir/test-recipe.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"canaryVersions": [
1717
{
1818
"dependencyOverrides": {
19-
"next": "latest"
19+
"next": "latest || *"
2020
}
2121
},
2222
{

packages/e2e-tests/test-applications/node-express-app/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88
"test": "playwright test"
99
},
1010
"dependencies": {
11-
"@sentry/integrations": "*",
12-
"@sentry/node": "*",
13-
"@sentry/tracing": "*",
14-
"@sentry/types": "*",
11+
"@sentry/integrations": "latest || *",
12+
"@sentry/node": "latest || *",
13+
"@sentry/tracing": "latest || *",
14+
"@sentry/types": "latest || *",
1515
"express": "4.18.2",
1616
"@types/express": "4.17.17",
1717
"@types/node": "18.15.1",

packages/e2e-tests/test-applications/react-create-hash-router/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"version": "0.1.0",
44
"private": true,
55
"dependencies": {
6-
"@sentry/react": "*",
6+
"@sentry/react": "latest || *",
77
"@testing-library/jest-dom": "5.14.1",
88
"@testing-library/react": "13.0.0",
99
"@testing-library/user-event": "13.2.1",

packages/e2e-tests/test-applications/react-create-hash-router/test-recipe.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
"canaryVersions": [
1212
{
1313
"dependencyOverrides": {
14-
"react": "latest",
15-
"react-dom": "latest"
14+
"react": "latest || *",
15+
"react-dom": "latest || *"
1616
}
1717
}
1818
]

packages/e2e-tests/test-applications/standard-frontend-react-tracing-import/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
"version": "0.1.0",
44
"private": true,
55
"dependencies": {
6-
"@sentry/react": "*",
7-
"@sentry/tracing": "*",
6+
"@sentry/react": "latest || *",
7+
"@sentry/tracing": "latest || *",
88
"@testing-library/jest-dom": "5.14.1",
99
"@testing-library/react": "13.0.0",
1010
"@testing-library/user-event": "13.2.1",

packages/e2e-tests/test-applications/standard-frontend-react/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"version": "0.1.0",
44
"private": true,
55
"dependencies": {
6-
"@sentry/react": "*",
6+
"@sentry/react": "latest || *",
77
"@testing-library/jest-dom": "5.14.1",
88
"@testing-library/react": "13.0.0",
99
"@testing-library/user-event": "13.2.1",

packages/e2e-tests/test-applications/standard-frontend-react/test-recipe.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
"canaryVersions": [
1919
{
2020
"dependencyOverrides": {
21-
"react": "latest",
22-
"react-dom": "latest"
21+
"react": "latest || *",
22+
"react-dom": "latest || *"
2323
}
2424
}
2525
]

packages/e2e-tests/test-applications/sveltekit/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"test:dev": "TEST_ENV=development playwright test"
1313
},
1414
"dependencies": {
15-
"@sentry/sveltekit": "*"
15+
"@sentry/sveltekit": "latest || *"
1616
},
1717
"devDependencies": {
1818
"@playwright/test": "^1.27.1",
@@ -29,8 +29,8 @@
2929
},
3030
"pnpm": {
3131
"overrides": {
32-
"@sentry/node": "*",
33-
"@sentry/tracing": "*"
32+
"@sentry/node": "latest || *",
33+
"@sentry/tracing": "latest || *"
3434
}
3535
},
3636
"type": "module"

0 commit comments

Comments
 (0)