Skip to content

Commit 4291519

Browse files
authored
Record error/message level in breadcrumb (fixes #580) (#633)
1 parent b99ff5d commit 4291519

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

src/raven.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1223,7 +1223,8 @@ Raven.prototype = {
12231223
this.captureBreadcrumb({
12241224
category: 'sentry',
12251225
message: data.message,
1226-
event_id: data.event_id
1226+
event_id: data.event_id,
1227+
level: data.level || 'error' // presume error unless specified
12271228
});
12281229

12291230
var url = this._globalEndpoint;

test/raven.test.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -633,7 +633,7 @@ describe('globals', function() {
633633
});
634634
});
635635

636-
it('should create and append \'error\' breadcrumb', function () {
636+
it('should create and append \'sentry\' breadcrumb', function () {
637637
this.sinon.stub(Raven, 'isSetup').returns(true);
638638
this.sinon.stub(Raven, '_makeRequest');
639639
this.sinon.stub(Raven, '_getHttpData').returns({
@@ -652,7 +652,14 @@ describe('globals', function() {
652652

653653
assert.deepEqual(Raven._breadcrumbs, [
654654
{ type: 'http', timestamp: 0.1, data: { method: 'POST', url: 'http://example.org/api/0/auth/' }},
655-
{ category: 'sentry', message: 'bar', timestamp: 0.1, /* 100ms */ event_id: 'abc123' }
655+
{ category: 'sentry', message: 'bar', timestamp: 0.1, /* 100ms */ event_id: 'abc123', level: 'error' }
656+
]);
657+
658+
Raven._send({message: 'foo', level: 'warning' });
659+
assert.deepEqual(Raven._breadcrumbs, [
660+
{ type: 'http', timestamp: 0.1, data: { method: 'POST', url: 'http://example.org/api/0/auth/' }},
661+
{ category: 'sentry', message: 'bar', timestamp: 0.1, /* 100ms */ event_id: 'abc123', level: 'error' },
662+
{ category: 'sentry', message: 'foo', timestamp: 0.1, /* 100ms */ event_id: 'abc123', level: 'warning' }
656663
]);
657664
});
658665

0 commit comments

Comments
 (0)