Skip to content

Commit 3c98e45

Browse files
authored
build(node-experimental): Update fastify instrumentation & E2E test (#9223)
E2E tests started failing for fastify because of 0.32.3 (https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-fastify/CHANGELOG.md) being released. This includes this change open-telemetry/opentelemetry-js-contrib#1680 (which actually we wrote xD) that changes some span names, which lead to E2E test failing.
1 parent 5fd5033 commit 3c98e45

File tree

3 files changed

+18
-7
lines changed

3 files changed

+18
-7
lines changed

packages/e2e-tests/test-applications/node-experimental-fastify-app/tests/transactions.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
4747
'http.route': '/test-transaction',
4848
'otel.kind': 'INTERNAL',
4949
},
50-
description: 'request handler - anonymous',
50+
description: 'request handler - fastify -> app-auto-0',
5151
parent_span_id: expect.any(String),
5252
span_id: expect.any(String),
5353
start_timestamp: expect.any(Number),

packages/node-experimental/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"@opentelemetry/context-async-hooks": "~1.17.0",
2929
"@opentelemetry/instrumentation": "~0.43.0",
3030
"@opentelemetry/instrumentation-express": "~0.33.1",
31-
"@opentelemetry/instrumentation-fastify": "~0.32.2",
31+
"@opentelemetry/instrumentation-fastify": "~0.32.3",
3232
"@opentelemetry/instrumentation-graphql": "~0.35.1",
3333
"@opentelemetry/instrumentation-http": "~0.43.0",
3434
"@opentelemetry/instrumentation-mongodb": "~0.37.0",

yarn.lock

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4367,13 +4367,13 @@
43674367
"@opentelemetry/semantic-conventions" "^1.0.0"
43684368
"@types/express" "4.17.17"
43694369

4370-
"@opentelemetry/instrumentation-fastify@~0.32.2":
4371-
version "0.32.2"
4372-
resolved "https://registry.yarnpkg.com/@opentelemetry/instrumentation-fastify/-/instrumentation-fastify-0.32.2.tgz#4af882938d3c05f7c7f5f860095e568728a2d838"
4373-
integrity sha512-DKa7SgxTtZ0O1ngGtAdwr/g8XguYw6KvLNME+J8rt6QpWQM+xytS0bg4atZAyt6aeYr/kO1sMrGXSlHEEYWIhg==
4370+
"@opentelemetry/instrumentation-fastify@~0.32.3":
4371+
version "0.32.3"
4372+
resolved "https://registry.yarnpkg.com/@opentelemetry/instrumentation-fastify/-/instrumentation-fastify-0.32.3.tgz#2c0640c986018d1a41dfff3d9c3bfe3b5b1cf62d"
4373+
integrity sha512-vRFVoEJXcu6nNpJ61H5syDb84PirOd4b3u8yl8Bcorrr6firGYBQH4pEIVB4PkQWlmi3sLOifqS3VAO2VRloEQ==
43744374
dependencies:
43754375
"@opentelemetry/core" "^1.8.0"
4376-
"@opentelemetry/instrumentation" "^0.41.2"
4376+
"@opentelemetry/instrumentation" "^0.44.0"
43774377
"@opentelemetry/semantic-conventions" "^1.0.0"
43784378

43794379
"@opentelemetry/instrumentation-graphql@~0.35.1":
@@ -4471,6 +4471,17 @@
44714471
semver "^7.5.2"
44724472
shimmer "^1.2.1"
44734473

4474+
"@opentelemetry/instrumentation@^0.44.0":
4475+
version "0.44.0"
4476+
resolved "https://registry.yarnpkg.com/@opentelemetry/instrumentation/-/instrumentation-0.44.0.tgz#194f16fc96671575b6bd73d3fadffb5aa4497e67"
4477+
integrity sha512-B6OxJTRRCceAhhnPDBshyQO7K07/ltX3quOLu0icEvPK9QZ7r9P1y0RQX8O5DxB4vTv4URRkxkg+aFU/plNtQw==
4478+
dependencies:
4479+
"@types/shimmer" "^1.0.2"
4480+
import-in-the-middle "1.4.2"
4481+
require-in-the-middle "^7.1.1"
4482+
semver "^7.5.2"
4483+
shimmer "^1.2.1"
4484+
44744485
"@opentelemetry/[email protected]":
44754486
version "1.17.0"
44764487
resolved "https://registry.yarnpkg.com/@opentelemetry/propagator-b3/-/propagator-b3-1.17.0.tgz#32509a8214b7ced7709fd06c0ee5a0d86adcc51f"

0 commit comments

Comments
 (0)