fix(replay): Improve handling of maskAllText selector (#6637)

Author: mydea

packages/replay/src/constants.ts

@@ -27,4 +27,4 @@ export const DEFAULT_SESSION_SAMPLE_RATE = 0.1;
 export const DEFAULT_ERROR_SAMPLE_RATE = 1.0;
 
 /** The select to use for the `maskAllText` option  */
-export const MASK_ALL_TEXT_SELECTOR = 'body *:not(style,script)';
+export const MASK_ALL_TEXT_SELECTOR = 'body *:not(style), body *:not(script)';

packages/replay/src/integration.ts

@@ -47,7 +47,8 @@ export class Replay implements Integration {
     useCompression = true,
     sessionSampleRate,
     errorSampleRate,
-    maskAllText = true,
+    maskAllText,
+    maskTextSelector,
     maskAllInputs = true,
     blockAllMedia = true,
     _experiments = {},
@@ -62,6 +63,7 @@ export class Replay implements Integration {
       blockClass,
       ignoreClass,
       maskTextClass,
+      maskTextSelector,
       blockSelector,
       ...recordingOptions,
     };
@@ -74,7 +76,7 @@ export class Replay implements Integration {
       sessionSampleRate: DEFAULT_SESSION_SAMPLE_RATE,
       errorSampleRate: DEFAULT_ERROR_SAMPLE_RATE,
       useCompression,
-      maskAllText,
+      maskAllText: typeof maskAllText === 'boolean' ? maskAllText : !maskTextSelector,
       blockAllMedia,
       _experiments,
     };

packages/replay/test/unit/index-integrationSettings.test.ts

@@ -184,7 +184,13 @@ describe('integration settings', () => {
       expect(replay['_recordingOptions'].maskTextSelector).toBe(undefined);
     });
 
-    it('overwrites custom maskTextSelector option', async () => {
+    it('maskTextSelector takes precedence over maskAllText when not specifiying maskAllText:true', async () => {
+      const { replay } = await mockSdk({ replayOptions: { maskTextSelector: '[custom]' } });
+
+      expect(replay['_recordingOptions'].maskTextSelector).toBe('[custom]');
+    });
+
+    it('maskAllText takes precedence over maskTextSelector when specifiying maskAllText:true', async () => {
       const { replay } = await mockSdk({ replayOptions: { maskAllText: true, maskTextSelector: '[custom]' } });
 
       expect(replay['_recordingOptions'].maskTextSelector).toBe(MASK_ALL_TEXT_SELECTOR);