Skip to content

Sentry integration code generated in the documentation for koa is using deprecated methods #8973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelwiles opened this issue Jan 26, 2024 · 7 comments

Comments

@michaelwiles
Copy link

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Go to https://docs.sentry.io/platforms/node/guides/koa/#monitor-performance
  2. See the generated integration code for koa
  3. Copy and paste that code into your project

Expected Result

Deprecated code messages should not be present

Actual Result

Deprecated code references are present.

Product Area

Help

Link

https://docs.sentry.io/platforms/node/guides/koa/#monitor-performance

DSN

No response

Version

No response

@getsantry
Copy link
Contributor

getsantry bot commented Jan 26, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Jan 26, 2024

Routing to @getsentry/product-owners-settings-integrations for triage ⏲️

@Dhrumil-Sentry Dhrumil-Sentry transferred this issue from getsentry/sentry Jan 26, 2024
@AbhiPrasad AbhiPrasad transferred this issue from getsentry/sentry-javascript Jan 26, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Jan 26, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Jan 26, 2024

Routing to @getsentry/product-owners-sdks-web-frontend for triage ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 2 Jan 26, 2024
@AbhiPrasad
Copy link
Member

Hi @michaelwiles - PRs are welcome, otherwise we are backlogging this to tackle as soon as we are done some of our other changes.

Deprecated methods should work fine for now - they were only recently deprecated in the last few minor versions of the SDK.

@mydea
Copy link
Member

mydea commented Feb 1, 2024

Generally, for this specific thing I think it's not worth it to refactor this deprecated code, because this will be completely changed in v8, when we can rely on OpenTelemetry for koa instrumentation. So keep an eye out for v8, where you hopefully won't have to manually instrument your koa app for performance anymore.

@AbhiPrasad
Copy link
Member

New Koa docs for 8.x: https://docs.sentry.io/platforms/javascript/guides/koa/

@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants