Skip to content

Commit c4f1c83

Browse files
committed
Apply suggestions from code review
1 parent c75f3b7 commit c4f1c83

File tree

14 files changed

+25
-21
lines changed

14 files changed

+25
-21
lines changed

src/platform-includes/getting-started-config/javascript.angular.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Sentry.init({
2525
// of transactions for performance monitoring.
2626
// We recommend adjusting this value in production
2727
tracesSampleRate: 1.0,
28-
28+
2929
// Capture Replay for 10% of all sessions,
3030
// plus for 100% of sessions with an error
3131
replaysSessionSampleRate: 0.1,

src/platform-includes/getting-started-config/javascript.ember.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Sentry.init({
1616
// of transactions for performance monitoring.
1717
// We recommend adjusting this value in production,
1818
tracesSampleRate: 1.0,
19-
19+
2020
// Capture Replay for 10% of all sessions,
2121
// plus for 100% of sessions with an error
2222
replaysSessionSampleRate: 0.1,

src/platform-includes/getting-started-config/javascript.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Sentry.init({
88

99
// Alternatively, use `process.env.npm_package_version` for a dynamic release version
1010
// if your build tool supports it.
11-
release: '[email protected]',
11+
release: "[email protected]",
1212
integrations: [new Sentry.BrowserTracing(), new Sentry.Replay()],
1313

1414
// Set tracesSampleRate to 1.0 to capture 100%

src/platform-includes/getting-started-config/javascript.react.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Sentry.init({
1212
// of transactions for performance monitoring.
1313
// We recommend adjusting this value in production
1414
tracesSampleRate: 1.0,
15-
15+
1616
// Capture Replay for 10% of all sessions,
1717
// plus for 100% of sessions with an error
1818
replaysSessionSampleRate: 0.1,

src/platform-includes/getting-started-config/javascript.remix.mdx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ To use this SDK, initialize Sentry in your Remix entry points for both the clien
22

33
Create two files in the root directory of your project, `entry.client.tsx` and `entry.server.tsx` (if they don't exist yet). In these files, add your initialization code for the client-side SDK and server-side SDK, respectively.
44

5-
The two configuration types are mostly the same, except that some configuration, like the one for Session Replay, only works in `entry.client.tsx`.
5+
The two configuration types are mostly the same, except that some configuration features, like Session Replay, only work in `entry.client.tsx`.
66

77
```typescript {tabTitle:Client} {filename: entry.client.tsx}
88
import { useLocation, useMatches } from "@remix-run/react";
@@ -22,12 +22,12 @@ Sentry.init({
2222
// Replay is only available in the client
2323
new Sentry.Replay(),
2424
],
25-
25+
2626
// Set tracesSampleRate to 1.0 to capture 100%
2727
// of transactions for performance monitoring.
2828
// We recommend adjusting this value in production
2929
tracesSampleRate: 1.0,
30-
30+
3131
// Capture Replay for 10% of all sessions,
3232
// plus for 100% of sessions with an error
3333
replaysSessionSampleRate: 0.1,
@@ -51,7 +51,7 @@ Sentry.init({
5151
),
5252
}),
5353
],
54-
54+
5555
// Set tracesSampleRate to 1.0 to capture 100%
5656
// of transactions for performance monitoring.
5757
// We recommend adjusting this value in production

src/platform-includes/getting-started-config/javascript.svelte.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Sentry.init({
1515
// of transactions for performance monitoring.
1616
// We recommend adjusting this value in production
1717
tracesSampleRate: 1.0,
18-
18+
1919
// Capture Replay for 10% of all sessions,
2020
// plus for 100% of sessions with an error
2121
replaysSessionSampleRate: 0.1,

src/platform-includes/getting-started-config/javascript.vue.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@ Sentry.init({
2222
}),
2323
new Sentry.Replay(),
2424
],
25-
25+
2626
// Set tracesSampleRate to 1.0 to capture 100%
2727
// of transactions for performance monitoring.
2828
// We recommend adjusting this value in production
2929
tracesSampleRate: 1.0,
30-
30+
3131
// Capture Replay for 10% of all sessions,
3232
// plus for 100% of sessions with an error
3333
replaysSessionSampleRate: 0.1,

src/platform-includes/getting-started-install/node.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ npm install --save @sentry/node
44

55
```bash {tabTitle:Yarn}
66
yarn add @sentry/node
7-
```
7+
```

src/platform-includes/set-fingerprint/database-connection/javascript.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Sentry.init({
77
const exception = hint.originalException;
88

99
if (exception instanceof DatabaseConnectionError) {
10-
event.fingerprint = ['database-connection-error'];
10+
event.fingerprint = ["database-connection-error"];
1111
}
1212

1313
return event;

src/platform-includes/set-fingerprint/rpc/javascript.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Sentry.init({
1818

1919
if (exception instanceof MyRPCError) {
2020
event.fingerprint = [
21-
'{{ default }}',
21+
"{{ default }}",
2222
String(exception.functionName),
2323
String(exception.errorCode),
2424
];

src/platforms/common/usage/sdk-fingerprinting.mdx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,18 @@ You can use variable substitution to fill dynamic values into the fingerprint ge
3333

3434
## Group Errors With Greater Granularity
3535

36-
Let's imagine your application queries a Remote Procedure Call Model (RPC) interface or external Application Programming Interface (API) service, so the stack trace is generally the same (even if the outgoing request is very different).
36+
In some scenarios, you'll want to group errors more granularly.
37+
38+
For example, if your application queries a Remote Procedure Call Model (RPC) interface or external Application Programming Interface (API) service, the stack trace is generally the same, even if the outgoing request is very different.
3739

3840
The following example will split up the default group Sentry would create (represented by `{{ default }}`) further, taking some attributes on the error object into account:
3941

4042
<PlatformContent includePath="set-fingerprint/rpc" />
4143

4244
## Group Errors More Aggressively
4345

44-
If a generic error, such as a database connection error, has many different stack traces and never groups them together, you can overwrite Sentry's grouping by omitting `{{ default }}` from the array:
46+
You can also overwrite Sentry's grouping entirely.
47+
48+
For example, if a generic error, such as a database connection error, has many different stack traces and never groups them together, you can overwrite Sentry's grouping by omitting `{{ default }}` from the array:
4549

4650
<PlatformContent includePath="set-fingerprint/database-connection" />

src/platforms/javascript/common/configuration/sentry-testkit/index.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ yarn add sentry-testkit --dev
2121
### Using in tests
2222

2323
```javascript
24-
import sentryTestkit from 'sentry-testkit';
24+
import sentryTestkit from "sentry-testkit";
2525

2626
const { testkit, sentryTransport } = sentryTestkit();
2727

src/platforms/javascript/guides/gatsby/index.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ Sentry.init({
4747
// of transactions for performance monitoring.
4848
// We recommend adjusting this value in production
4949
tracesSampleRate: 1.0,
50-
50+
5151
// Capture Replay for 10% of all sessions,
5252
// plus for 100% of sessions with an error
5353
replaysSessionSampleRate: 0.1,
5454
replaysOnErrorSampleRate: 1.0,
5555
});
56-
```
56+
```

src/platforms/javascript/guides/nextjs/manual-setup.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ If you're updating your Sentry SDK to the latest version, check out our [migrati
2626

2727
Create three files in the root directory of your project, `sentry.client.config.js`, `sentry.server.config.js` and `sentry.edge.config.js`. In these files, add your initialization code for the client-side SDK and server-side SDK, respectively. We've included some examples below.
2828

29-
The three configuration types are mostly the same, except that some configuration, like the one for Session Replay, only works in `sentry.client.config.js`.
29+
Please note that there are slight differences between these files since they run in different places (browser, server, edge), so copy them carefully!
3030

3131
```javascript {tabTitle:Client} {filename:sentry.client.config.(js|ts)}
3232
import * as Sentry from "@sentry/nextjs";
@@ -40,7 +40,7 @@ Sentry.init({
4040
// of transactions for performance monitoring.
4141
// We recommend adjusting this value in production
4242
tracesSampleRate: 1.0,
43-
43+
4444
// Capture Replay for 10% of all sessions,
4545
// plus for 100% of sessions with an error
4646
replaysSessionSampleRate: 0.1,

0 commit comments

Comments
 (0)