From 7f39851d33daa5f0cfb03e321455f2fc5b76a4ac Mon Sep 17 00:00:00 2001 From: GIancarlo Buenaflor Date: Thu, 18 Jul 2024 17:11:31 +0200 Subject: [PATCH 1/2] disable --- flutter/lib/src/sentry_flutter.dart | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/flutter/lib/src/sentry_flutter.dart b/flutter/lib/src/sentry_flutter.dart index 4b0deb8541..6a96c567dc 100644 --- a/flutter/lib/src/sentry_flutter.dart +++ b/flutter/lib/src/sentry_flutter.dart @@ -136,7 +136,11 @@ mixin SentryFlutter { options.addEventProcessor(PlatformExceptionEventProcessor()); - options.addPerformanceCollector(SpanFrameMetricsCollector(options)); + if (options.platformChecker.platform.isAndroid || + options.platformChecker.platform.isIOS || + options.platformChecker.platform.isMacOS) { + options.addPerformanceCollector(SpanFrameMetricsCollector(options)); + } _setSdk(options); } From e71e27633bf35c8ddbfa516df574a2c9101980ac Mon Sep 17 00:00:00 2001 From: GIancarlo Buenaflor Date: Fri, 19 Jul 2024 10:33:03 +0200 Subject: [PATCH 2/2] update --- CHANGELOG.md | 5 +++++ flutter/lib/src/sentry_flutter.dart | 1 + 2 files changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e1da39b4b1..9e8f190369 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,11 @@ ## Unreleased +### Fixes + +- Disable sff & frame delay detection on web, linux and windows ([#2182](https://github.com/getsentry/sentry-dart/pull/2182)) + - Display refresh rate is locked at 60 for these platforms which can lead to inaccurate metrics + ### Improvements - Capture meaningful stack traces when unhandled errors have empty or missing stack traces ([#2152](https://github.com/getsentry/sentry-dart/pull/2152)) diff --git a/flutter/lib/src/sentry_flutter.dart b/flutter/lib/src/sentry_flutter.dart index 6a96c567dc..42d3cd1ea2 100644 --- a/flutter/lib/src/sentry_flutter.dart +++ b/flutter/lib/src/sentry_flutter.dart @@ -136,6 +136,7 @@ mixin SentryFlutter { options.addEventProcessor(PlatformExceptionEventProcessor()); + // Disabled for web, linux and windows until we can reliably get the display refresh rate if (options.platformChecker.platform.isAndroid || options.platformChecker.platform.isIOS || options.platformChecker.platform.isMacOS) {