Skip to content

Commit 0a64169

Browse files
chore(metrics): Remove send-metric command (#3006)
### Description Removed all `sentry-cli send-metric` subcommands. This is basically the resurrection of #2710 🧟 (πŸ₯” @vgrozdanic). ### Issues - Resolves #2713 - Resolves [CLI-157](https://linear.app/getsentry/issue/CLI-157/remove-send-metric-commands) __ Co-authored-by: Daniel Szoke <[email protected]>
1 parent f1aed1b commit 0a64169

File tree

48 files changed

+19
-667
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+19
-667
lines changed

β€ŽCHANGELOG.mdβ€Ž

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ we should rename this section to "Unreleased" -->
1414

1515
- Removed all `sentry-cli files ...` and `sentry-cli releases files ...` subcommands ([#2956](https://github.com/getsentry/sentry-cli/pull/2956)). These commands provided functionality for managing release files, a feature that has been deprecated in Sentry. Users still using `sentry-cli files upload` to upload source maps should migrate to `sentry-cli sourcemaps upload`.
1616
- Removed the `sentry-cli sourcemaps explain` command ([#2947](https://github.com/getsentry/sentry-cli/pull/2947)). The command had been deprecated for some time, since Sentry now has a better in-product debugging flow for source map problems via the "Unminify Code" button, which is displayed on any JavaScript issues which could not be unminified.
17+
- Removed the `sentry-cli send-metric ...` subcommands ([#TODO](XXXX)). These commands have been deprecated, and the data they send is no longer accepted by Sentry.
1718
- Removed support for the legacy API key authentication method ([#2935](https://github.com/getsentry/sentry-cli/pull/2935)). Sentry CLI now only supports authenticating with Auth Tokens. If you are using API key authentication via any of the following methods, you need to generate and use an [Auth Token](https://docs.sentry.io/account/auth-tokens/), instead:
1819
- `--api-key` CLI flag
1920
- `SENTRY_API_KEY` environment variable

β€ŽCargo.lockβ€Ž

Lines changed: 17 additions & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€ŽCargo.tomlβ€Ž

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,10 @@ regex = "1.7.3"
5454
runas = "1.0.0"
5555
rust-ini = "0.18.0"
5656
semver = "1.0.16"
57-
sentry = { version = "0.34.0", default-features = false, features = [
57+
sentry = { version = "0.46.0", default-features = false, features = [
5858
"anyhow",
5959
"curl",
6060
"contexts",
61-
"metrics",
6261
] }
6362
serde = { version = "1.0.152", features = ["derive"] }
6463
serde_json = "1.0.93"

β€Žsrc/commands/derive_parser.rsβ€Ž

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ use clap::{command, ArgAction::SetTrue, Parser, Subcommand};
44

55
use super::dart_symbol_map::DartSymbolMapArgs;
66
use super::logs::LogsArgs;
7-
use super::send_metric::SendMetricArgs;
87

98
#[derive(Parser)]
109
pub(super) struct SentryCLI {
@@ -35,6 +34,5 @@ pub(super) struct SentryCLI {
3534
#[derive(Subcommand)]
3635
pub(super) enum SentryCLICommand {
3736
Logs(LogsArgs),
38-
SendMetric(SendMetricArgs),
3937
DartSymbolMap(DartSymbolMapArgs),
4038
}

β€Žsrc/commands/logs/mod.rsβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ pub(super) fn execute(_: &ArgMatches) -> Result<()> {
4242
let SentryCLICommand::Logs(LogsArgs { subcommand }) = SentryCLI::parse().command else {
4343
unreachable!("expected logs subcommand");
4444
};
45-
4645
eprintln!("{BETA_WARNING}");
4746

4847
match subcommand {

β€Žsrc/commands/mod.rsβ€Ž

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ mod releases;
3838
mod repos;
3939
mod send_envelope;
4040
mod send_event;
41-
mod send_metric;
4241
mod sourcemaps;
4342
#[cfg(not(feature = "managed"))]
4443
mod uninstall;
@@ -67,7 +66,6 @@ macro_rules! each_subcommand {
6766
$mac!(repos);
6867
$mac!(send_event);
6968
$mac!(send_envelope);
70-
$mac!(send_metric);
7169
$mac!(sourcemaps);
7270
$mac!(dart_symbol_map);
7371
#[cfg(not(feature = "managed"))]

β€Žsrc/commands/send_metric/common_args.rsβ€Ž

Lines changed: 0 additions & 67 deletions
This file was deleted.

β€Žsrc/commands/send_metric/distribution.rsβ€Ž

Lines changed: 0 additions & 15 deletions
This file was deleted.

β€Žsrc/commands/send_metric/gauge.rsβ€Ž

Lines changed: 0 additions & 15 deletions
This file was deleted.

β€Žsrc/commands/send_metric/increment.rsβ€Ž

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
Β (0)