Skip to content

Commit 993a54f

Browse files
committed
test: be explicit instead of import
1 parent da5404b commit 993a54f

File tree

4 files changed

+89
-126
lines changed

4 files changed

+89
-126
lines changed

+stdlib/+test/TestFilePure.m

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,28 +3,24 @@
33
methods (Test)
44

55
function test_posix(tc)
6-
import stdlib.posix
76

8-
tc.verifyEmpty(posix(string.empty))
9-
tc.verifyEqual(posix(""), "")
7+
tc.verifyEmpty(stdlib.posix(string.empty))
8+
tc.verifyEqual(stdlib.posix(""), "")
109

1110
if ispc
12-
tc.verifyFalse(contains(posix("c:\foo"), "\"))
13-
tc.verifyFalse(all(contains(posix(["x:\123", "d:\abc"]), "\")))
11+
tc.verifyFalse(contains(stdlib.posix("c:\foo"), "\"))
12+
tc.verifyFalse(all(contains(stdlib.posix(["x:\123", "d:\abc"]), "\")))
1413
end
1514
end
1615

1716
function test_samepath(tc)
18-
19-
import stdlib.samepath
20-
2117
tc.assumeTrue(usejava("jvm"), "Java required for samepath")
2218

23-
tc.verifyEmpty(samepath(string.empty, string.empty))
24-
tc.verifyTrue(samepath("", ""))
25-
tc.verifyFalse(samepath("a", "b"))
26-
tc.verifyTrue(samepath("a/b/..", "a/c/.."))
27-
tc.verifyTrue(samepath(".", "a/.."))
19+
tc.verifyEmpty(stdlib.samepath(string.empty, string.empty))
20+
tc.verifyTrue(stdlib.samepath("", ""))
21+
tc.verifyFalse(stdlib.samepath("a", "b"))
22+
tc.verifyTrue(stdlib.samepath("a/b/..", "a/c/.."))
23+
tc.verifyTrue(stdlib.samepath(".", "a/.."))
2824

2925
end
3026

+stdlib/+test/TestHDF5.m

Lines changed: 32 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
methods (TestMethodSetup)
1313

1414
function setup_file(tc)
15-
import stdlib.h5save
16-
import matlab.unittest.constraints.IsFile
1715

1816
A0 = 42.;
1917
A1 = [42.; 43.];
@@ -36,20 +34,20 @@ function setup_file(tc)
3634
tc.TestData.basic = basic;
3735

3836
% create test data first, so that parallel tests works
39-
h5save(basic, '/A0', A0)
40-
h5save(basic, '/A1', A1)
41-
h5save(basic, '/A2', A2)
42-
h5save(basic, '/A3', A3, "size", size(A3))
43-
h5save(basic, '/A4', A4)
37+
stdlib.h5save(basic, '/A0', A0)
38+
stdlib.h5save(basic, '/A1', A1)
39+
stdlib.h5save(basic, '/A2', A2)
40+
stdlib.h5save(basic, '/A3', A3, "size", size(A3))
41+
stdlib.h5save(basic, '/A4', A4)
4442

45-
h5save(basic, "/utf", utf)
46-
h5save(basic, "/utf2", utf2)
43+
stdlib.h5save(basic, "/utf", utf)
44+
stdlib.h5save(basic, "/utf2", utf2)
4745

48-
h5save(basic, '/t/x', 12)
49-
h5save(basic, '/t/y', 13)
50-
h5save(basic, '/j/a/b', 6)
46+
stdlib.h5save(basic, '/t/x', 12)
47+
stdlib.h5save(basic, '/t/y', 13)
48+
stdlib.h5save(basic, '/j/a/b', 6)
5149

52-
tc.assumeThat(basic, IsFile)
50+
tc.assumeTrue(isfile(basic))
5351
end
5452
end
5553

@@ -73,93 +71,89 @@ function test_auto_chunk_size(tc)
7371

7472

7573
function test_get_variables(tc)
76-
import stdlib.h5variables
7774

7875
basic = tc.TestData.basic;
7976

80-
v = h5variables(basic);
77+
v = stdlib.h5variables(basic);
8178
k = ["A0", "A1", "A2", "A3", "A4", "utf", "utf2"];
8279
tc.verifyEqual(sort(v), k)
8380

8481
% 1-level group
85-
v = h5variables(basic, "/t");
82+
v = stdlib.h5variables(basic, "/t");
8683
tc.verifyEqual(sort(v), ["x", "y"])
8784

8885
% traversal
89-
tc.verifyEmpty( h5variables(basic, "/j") )
86+
tc.verifyEmpty(stdlib.h5variables(basic, "/j") )
9087

91-
tc.verifyEqual( h5variables(basic, "/j/a") , "b")
88+
tc.verifyEqual(stdlib.h5variables(basic, "/j/a") , "b")
9289

9390
end
9491

9592

9693
function test_exists(tc)
97-
import stdlib.h5exists
9894
basic = tc.TestData.basic;
9995

100-
tc.verifyEmpty(h5exists(basic, string.empty))
96+
tc.verifyEmpty(stdlib.h5exists(basic, string.empty))
10197

102-
e = h5exists(basic, "");
98+
e = stdlib.h5exists(basic, "");
10399

104100
tc.verifyTrue(isscalar(e))
105101
tc.verifyFalse(e)
106102

107103
vars = {'A0', 'A1', 'A2', 'A3', 'A4', '/A0'};
108104

109-
e = h5exists(basic, vars);
105+
e = stdlib.h5exists(basic, vars);
110106
tc.verifyTrue(isvector(e))
111107
tc.verifyTrue(all(e))
112108

113109
% vector
114-
e = h5exists(basic, ["/A1", "oops"]);
110+
e = stdlib.h5exists(basic, ["/A1", "oops"]);
115111
tc.verifyTrue(isrow(e))
116112
tc.verifyEqual(e, [true, false])
117113
end
118114

119115

120116
function test_size(tc)
121-
122-
import stdlib.h5ndims
123117
basic = tc.TestData.basic;
124118

125-
tc.verifyEmpty(h5ndims(basic, string.empty))
126-
tc.verifyEmpty(h5ndims(basic, ""))
119+
tc.verifyEmpty(stdlib.h5ndims(basic, string.empty))
120+
tc.verifyEmpty(stdlib.h5ndims(basic, ""))
127121

128-
r = h5ndims(basic, '/A0');
122+
r = stdlib.h5ndims(basic, '/A0');
129123
s = stdlib.h5size(basic, '/A0');
130124
tc.verifyEmpty(s)
131125
tc.verifyEqual(r, 0)
132126

133-
r = h5ndims(basic, '/A1');
127+
r = stdlib.h5ndims(basic, '/A1');
134128
s = stdlib.h5size(basic, '/A1');
135129
tc.verifyTrue(isscalar(s))
136130
tc.verifyEqual(s, 2)
137131
tc.verifyEqual(r, 1)
138132

139-
r = h5ndims(basic, '/A2');
133+
r = stdlib.h5ndims(basic, '/A2');
140134
s = stdlib.h5size(basic, '/A2');
141135
tc.verifyTrue(isvector(s))
142136
tc.verifyEqual(s, [4,4])
143137
tc.verifyEqual(r, 2)
144138

145-
r = h5ndims(basic, '/A3');
139+
r = stdlib.h5ndims(basic, '/A3');
146140
s = stdlib.h5size(basic, '/A3');
147141
tc.verifyTrue(isvector(s))
148142
tc.verifyEqual(s, [4,3,2])
149143
tc.verifyEqual(r, 3)
150144

151-
r = h5ndims(basic, '/A4');
145+
r = stdlib.h5ndims(basic, '/A4');
152146
s = stdlib.h5size(basic, '/A4');
153147
tc.verifyTrue(isvector(s))
154148
tc.verifyEqual(s, [4,3,2,5])
155149
tc.verifyEqual(r, 4)
156150

157-
r = h5ndims(basic, '/utf');
151+
r = stdlib.h5ndims(basic, '/utf');
158152
s = stdlib.h5size(basic, '/utf');
159153
tc.verifyEmpty(s)
160154
tc.verifyEqual(r, 0)
161155

162-
r = h5ndims(basic, '/utf2');
156+
r = stdlib.h5ndims(basic, '/utf2');
163157
s = stdlib.h5size(basic, '/utf2');
164158
tc.verifyEqual(s, 2)
165159
tc.verifyEqual(r, 1)
@@ -216,7 +210,6 @@ function test_shape(tc)
216210

217211

218212
function test_coerce(tc)
219-
import matlab.unittest.constraints.IsFile
220213
basic = tc.TestData.basic;
221214

222215
for type = ["single", "double", ...
@@ -232,32 +225,30 @@ function test_coerce(tc)
232225

233226

234227
function test_rewrite(tc)
235-
import matlab.unittest.constraints.IsFile
236228
basic = tc.TestData.basic;
237229

238230
stdlib.h5save(basic, '/A2', 3*magic(4))
239231

240-
tc.assumeThat(basic, IsFile)
232+
tc.assumeTrue(isfile(basic))
241233
tc.verifyEqual(h5read(basic, '/A2'), 3*magic(4))
242234
end
243235

244236
function test_int8(tc)
245-
import stdlib.h5save
246237
basic = tc.TestData.basic;
247238

248-
h5save(basic, "/i1", int8(127))
239+
stdlib.h5save(basic, "/i1", int8(127))
249240

250241
a = h5read(basic, "/i1");
251242
tc.verifyEqual(a, int8(127))
252243

253244
% test rewrite
254-
h5save(basic, "/i1", int8(-128))
245+
stdlib.h5save(basic, "/i1", int8(-128))
255246

256247
a = h5read(basic, "/i1");
257248
tc.verifyEqual(a, int8(-128))
258249

259250
% test int8 array
260-
h5save(basic, "/Ai1", int8([1, 2]))
251+
stdlib.h5save(basic, "/Ai1", int8([1, 2]))
261252
a = h5read(basic, "/Ai1");
262253
tc.verifyEqual(a, int8([1;2]))
263254
end

0 commit comments

Comments
 (0)