-
Notifications
You must be signed in to change notification settings - Fork 70
feat: Send a notification to reviewers on new comment #2997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Send a notification to reviewers on new comment #2997
Conversation
Reviewers will now get notified when a new comment is added to a line they previously commented on Closes: 2849
|
@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #2997 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 191 191
Lines 3582 3606 +24
Branches 972 979 +7
=========================================
+ Hits 3582 3606 +24
|
…3-app into 2849-reviewers-notifications
This commit is unrelated to the current PR, but it's required for the CI to pass and the local pre-push hook to pass
Overview
Currently, when a student receives a comment from a reviewer on their submission and attempts to reply to it, the reviewer doesn't get a notification. This behavior introduces difficulty in communication between the student and the reviewer, as the reviewer's only way to find out about the new comments by the student is to frequently visit the website. It can quickly degrade productivity for both the student who is trying to learn and the reviewers who are trying to teach.
Solution
Send a notification to all the people who wrote a comment on a certain submission's line except the comment author.
Missing requirements
There are some things this PR does not introduce that are crucial for having an ideal notification system.
These shall be addressed in the project of adding a notification system (I could not find the issue for this project, but it did exist). @SlyBouhafs, any references?
Changes
addCommentresolver.Unrelated changes
These changes are not related to this PR, but they were required in order for the CI/CD to pass
exercises/[lessonSlug].tsxpage by waiting for the router to be readyIdeal solution
I believe this is not the ideal solution because sending simultaneous requests to our Discord bot server could overload the server and, by extension, slow down the server for other users. As of now, we don't have a lot of active users, and the comment section is almost always 1:1.
Related PR