Skip to content

Conversation

@HS-90
Copy link
Collaborator

@HS-90 HS-90 commented Sep 9, 2022

Title: enhancement : adds ability to edit comments on a submission
Description: closes #893

This PR will allow users to edit their own comments on submissions from the frontend. Clicking the edit button will allow users to make changes to existing comments, as well as discarding changes, which will revert the comment to it's original state pr previously saved edit.

To test: login as a Dummy 'Admin' user, try to create then edit existing comments. You can then log out and login as another user(such as 'Leetcoder'), You should now see that you can no longer edit or delete comments that were created by "Admin".

Note: querySelector classes were used to select button elements in the test file, as our custom Button components do not accept test-id as a prorp

@vercel
Copy link

vercel bot commented Sep 9, 2022

@HS-90 is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
c0d3-app ✅ Ready (Inspect) Visit Preview Sep 11, 2022 at 4:17PM (UTC)

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #2278 (a0d4e76) into master (77ff375) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2278   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          177       177           
  Lines         3036      3066   +30     
  Branches       811       818    +7     
=========================================
+ Hits          3036      3066   +30     
Impacted Files Coverage Δ
components/SubmissionComments.tsx 100.00% <100.00%> (ø)

Copy link
Member

@flacial flacial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool feature!

@HS-90 HS-90 merged commit 3936e06 into garageScript:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit/delete comments

5 participants