Merge pull request #222 from brettz9/no-undefined-types-node

Ensure `no-undefined-types` catches modular scope for Node/commonjs env's

Author: brettz9

README.md

@@ -1371,6 +1371,13 @@ function quux(foo) {
 
 }
 
+/**
+ * @param {Promise} foo - Bar.
+ */
+function quux(foo) {
+
+}
+
 class MyClass {}
 
 /**
@@ -1391,6 +1398,15 @@ const MyType = require('my-library').MyType;
 
 }
 
+const MyType = require('my-library').MyType;
+
+/**
+ * @param {MyType} foo - Bar.
+ */
+  function quux(foo) {
+
+}
+
 import {MyType} from 'my-library';
 
 /**
@@ -1402,7 +1418,7 @@ import {MyType} from 'my-library';
 
 }
 
-/*global MyType*/
+/*globals MyType*/
 
 /**
  * @param {MyType} foo - Bar.

src/rules/noUndefinedTypes.js

@@ -51,9 +51,20 @@ export default iterateJsdoc(({
   })
 
     // If the file is a module, concat the variables from the module scope.
-    .concat(scopeManager.isModule() ? globalScope.childScopes[0].variables.map((variable) => {
-      return variable.name;
-    }) : [])
+    .concat(
+
+      // This covers `commonjs` as well as `node`
+      scopeManager.__options.nodejsScope ||
+      scopeManager.isModule() ?
+        globalScope.childScopes.reduce((arr, {variables}) => {
+          // Flatten
+          arr.push(...variables);
+
+          return arr;
+        }, []).map(({name}) => {
+          return name;
+        }) : []
+    )
     .concat(extraTypes)
     .concat(typedefDeclarations);
 

test/rules/assertions/noUndefinedTypes.js

@@ -31,6 +31,19 @@ export default {
           }
       `
     },
+    {
+      code: `
+          /**
+           * @param {Promise} foo - Bar.
+           */
+          function quux(foo) {
+
+          }
+      `,
+      env: {
+        es6: true
+      }
+    },
     {
       code: `
           class MyClass {}
@@ -58,7 +71,25 @@ export default {
           function quux(foo) {
 
         }
-      `
+      `,
+      env: {
+        node: true
+      }
+    },
+    {
+      code: `
+        const MyType = require('my-library').MyType;
+
+        /**
+         * @param {MyType} foo - Bar.
+         */
+          function quux(foo) {
+
+        }
+      `,
+      env: {
+        node: false
+      }
     },
     {
       code: `
@@ -79,7 +110,7 @@ export default {
     },
     {
       code: `
-        /*global MyType*/
+        /*globals MyType*/
 
         /**
          * @param {MyType} foo - Bar.