#3 remove unnecessary @throws, rename argument to option

Author: agabrys

src/main/java/biz/gabrys/lesscss/compiler2/Less175Compiler.java

@@ -98,7 +98,7 @@ public Less175Compiler() {
      * @since 2.0.0
      */
     @Override
-    public String execute(final File source) throws CompilerException {
+    public String execute(final File source) {
         return execute(source, new Less175CompilerOptionsBuilder().create());
     }
 
@@ -141,7 +141,7 @@ public String execute(final File input, final Collection<Object> options) {
         }
     }
 
-    private void initialize() throws InitializationException {
+    private void initialize() {
         InputStream inputStream = null;
         InputStreamReader streamReader = null;
         try {

src/main/java/biz/gabrys/lesscss/compiler2/Less175CompilerOptionsBuilder.java

@@ -81,12 +81,12 @@ public Less175CompilerOptionsBuilder withSilent(final boolean silent) {
     }
 
     /**
-     * Returns a command line argument which enables/disables logging compilation warnings.
-     * @return the command line argument (never {@code null}).
+     * Returns a command line option which enables/disables logging compilation warnings.
+     * @return the command line option (never {@code null}).
      * @since 2.0.0
      * @see #withSilent(boolean)
      */
-    protected String getSilentCompilerArgument() {
+    protected String getSilentCompilerOption() {
         if (silent) {
             return "--silent";
         } else {
@@ -108,12 +108,12 @@ public Less175CompilerOptionsBuilder withStrictImports(final boolean strictImpor
     }
 
     /**
-     * Returns a command line argument which enables/disables strict imports.
-     * @return the command line argument (never {@code null}).
+     * Returns a command line option which enables/disables strict imports.
+     * @return the command line option (never {@code null}).
      * @since 2.0.0
      * @see #withStrictImports(boolean)
      */
-    protected String getStrictImportsCompilerArgument() {
+    protected String getStrictImportsCompilerOption() {
         if (strictImports) {
             return "--strict-imports";
         } else {
@@ -133,12 +133,12 @@ public Less175CompilerOptionsBuilder withCompress(final boolean compress) {
     }
 
     /**
-     * Returns a command line argument which enables/disables a CSS code compression.
-     * @return the command line argument (never {@code null}).
+     * Returns a command line option which enables/disables a CSS code compression.
+     * @return the command line option (never {@code null}).
      * @since 2.0.0
      * @see #withCompress(boolean)
      */
-    protected String getCompressCompilerArgument() {
+    protected String getCompressCompilerOption() {
         if (compress) {
             return "--compress";
         } else {
@@ -159,11 +159,11 @@ public Less175CompilerOptionsBuilder withDepends(final boolean depends) {
 
     /**
      * TODO what is depends?
-     * @return command line argument (never {@code null}).
+     * @return command line option (never {@code null}).
      * @since 2.0.0
      * @see #withDepends(boolean)
      */
-    protected String getDependsCompilerArgument() {
+    protected String getDependsCompilerOption() {
         if (depends) {
             return "--depends";
         } else {
@@ -185,12 +185,12 @@ public Less175CompilerOptionsBuilder withIeCompatability(final boolean ieCompata
     }
 
     /**
-     * Returns a command line argument which enables/disables compatibility with IE browser.
-     * @return the command line argument (never {@code null}).
+     * Returns a command line option which enables/disables compatibility with IE browser.
+     * @return the command line option (never {@code null}).
      * @since 2.0.0
      * @see #withIeCompatability(boolean)
      */
-    protected String getIeCompatabilityCompilerArgument() {
+    protected String getIeCompatabilityCompilerOption() {
         if (ieCompatability) {
             return "";
         } else {
@@ -211,12 +211,12 @@ public Less175CompilerOptionsBuilder withJavaScriptEnabled(final boolean javaScr
     }
 
     /**
-     * Returns a command line argument which allows/disallows usage of JavaScript language.
-     * @return the command line argument (never {@code null}).
+     * Returns a command line option which allows/disallows usage of JavaScript language.
+     * @return the command line option (never {@code null}).
      * @since 2.0.0
      * @see #withJavaScriptEnabled(boolean)
      */
-    protected String getJavaScriptEnabledCompilerArgument() {
+    protected String getJavaScriptEnabledCompilerOption() {
         if (javaScriptEnabled) {
             return "";
         } else {
@@ -243,12 +243,12 @@ public Less175CompilerOptionsBuilder withIncludePaths(final List<String> include
     }
 
     /**
-     * Returns a command line argument representation of the available include paths.
-     * @return the command line argument (never {@code null}).
+     * Returns a command line option representation of the available include paths.
+     * @return the command line option (never {@code null}).
      * @since 2.0.0
      * @see #withIncludePaths(List)
      */
-    protected String getIncludePathsCompilerArgument() {
+    protected String getIncludePathsCompilerOption() {
         if (includePaths.isEmpty()) {
             return "";
         }
@@ -278,12 +278,12 @@ public Less175CompilerOptionsBuilder withLineNumbers(final LineNumbersValue line
     }
 
     /**
-     * Returns a command line argument which enables/disables generating inline source-mapping.
-     * @return the command line argument (never {@code null}).
+     * Returns a command line option which enables/disables generating inline source-mapping.
+     * @return the command line option (never {@code null}).
      * @since 2.0.0
      * @see #withJavaScriptEnabled(boolean)
      */
-    protected String getLineNumbersCompilerArgument() {
+    protected String getLineNumbersCompilerOption() {
         if (lineNumbers == LineNumbersValue.DISABLED) {
             return "";
         } else {
@@ -312,12 +312,12 @@ public Less175CompilerOptionsBuilder withRootPath(final String rootPath) {
     }
 
     /**
-     * Returns a command line argument representation of the root path.
-     * @return the command line argument (never {@code null}).
+     * Returns a command line option representation of the root path.
+     * @return the command line option (never {@code null}).
      * @since 2.0.0
      * @see #withRootPath(String)
      */
-    protected String getRootPathCompilerArgument() {
+    protected String getRootPathCompilerOption() {
         if (rootPath != null) {
             return "--rootpath=" + rootPath;
         } else {
@@ -340,25 +340,28 @@ protected String getRootPathCompilerArgument() {
      *     background-image: url('images/lamp-post.png');
      * }
      * </pre>
-     * 
+     * <p>
      * this will output the following normally
+     * </p>
      * 
      * <pre>
      * .icon-1 {
      *     background-image: url('images/lamp-post.png');
      * }
      * </pre>
-     * 
+     * <p>
      * but with this option on it will instead output
+     * </p>
      * 
      * <pre>
      * .icon-1 {
      *     background-image: url('files/images/lamp-post.png');
      * }
      * </pre>
-     * 
+     * <p>
      * You may also want to consider using the {@code data-uri} function instead of this option, which will embed images
      * into the CSS.
+     * </p>
      * @param relativeUrls {@code true} whether the compiler should rewrite relative URLs, otherwise {@code false}.
      * @return {@code this} builder.
      * @since 2.0.0
@@ -369,12 +372,12 @@ public Less175CompilerOptionsBuilder withRelativeUrls(final boolean relativeUrls
     }
 
     /**
-     * Returns a command line argument which enables/disables rewriting relative URLs.
-     * @return the command line argument (never {@code null}).
+     * Returns a command line option which enables/disables rewriting relative URLs.
+     * @return the command line option (never {@code null}).
      * @since 2.0.0
      * @see #withRelativeUrls(boolean)
      */
-    protected String getRelativeUrlsCompilerArgument() {
+    protected String getRelativeUrlsCompilerOption() {
         if (relativeUrls) {
             return "--relative-urls";
         } else {
@@ -391,8 +394,9 @@ protected String getRelativeUrlsCompilerArgument() {
      *     height: calc(100% - 10px);
      * }
      * </pre>
-     * 
+     * <p>
      * will be processed currently.
+     * </p>
      * <p>
      * With strict math on, only maths that is inside unnecessary parenthesis will be processed. For instance.
      * </p>
@@ -424,12 +428,12 @@ public Less175CompilerOptionsBuilder withStrictMath(final boolean strictMath) {
     }
 
     /**
-     * Returns a command line argument which enables/disables strict math.
-     * @return the command line argument (never {@code null}).
+     * Returns a command line option which enables/disables strict math.
+     * @return the command line option (never {@code null}).
      * @since 2.0.0
      * @see #withStrictMath(boolean)
      */
-    protected String getStrictMathCompilerArgument() {
+    protected String getStrictMathCompilerOption() {
         if (strictMath) {
             return "--strict-math=on";
         } else {
@@ -446,11 +450,12 @@ protected String getStrictMathCompilerArgument() {
      *     property: 1px * 2px;
      * }
      * </pre>
-     * 
+     * <p>
      * In this case, things are clearly not right - a length multiplied by a length gives an area, but CSS does not
      * support specifying areas. So we assume that the user meant for one of the values to be a value, not a unit of
      * length and Less outputs 2px. With strict units on, Less assumes this is a bug in the calculation and throw an
      * error.
+     * </p>
      * @param strictUnits {@code true} whether the compiler should guess units in the Less code when it does maths,
      *            otherwise {@code false}.
      * @return {@code this} builder.
@@ -462,12 +467,12 @@ public Less175CompilerOptionsBuilder withStrictUnits(final boolean strictUnits)
     }
 
     /**
-     * Returns a command line argument which enables/disables strict units.
-     * @return the command line argument (never {@code null}).
+     * Returns a command line option which enables/disables strict units.
+     * @return the command line option (never {@code null}).
      * @since 2.0.0
      * @see #withStrictUnits(boolean)
      */
-    protected String getStrictUnitsCompilerArgument() {
+    protected String getStrictUnitsCompilerOption() {
         if (strictUnits) {
             return "--strict-units=on";
         } else {
@@ -481,20 +486,20 @@ protected String getStrictUnitsCompilerArgument() {
      * @since 2.0.0
      */
     public Collection<Object> create() {
-        final ListWithoutEmptyValuesBuilder arguments = new ListWithoutEmptyValuesBuilder();
-        arguments.add(getSilentCompilerArgument());
-        arguments.add(getStrictImportsCompilerArgument());
-        arguments.add(getCompressCompilerArgument());
-        arguments.add(getDependsCompilerArgument());
-        arguments.add(getIeCompatabilityCompilerArgument());
-        arguments.add(getJavaScriptEnabledCompilerArgument());
-        arguments.add(getIncludePathsCompilerArgument());
-        arguments.add(getLineNumbersCompilerArgument());
-        arguments.add(getRootPathCompilerArgument());
-        arguments.add(getRelativeUrlsCompilerArgument());
-        arguments.add(getStrictMathCompilerArgument());
-        arguments.add(getStrictUnitsCompilerArgument());
-        return arguments.create();
+        final ListWithoutEmptyValuesBuilder options = new ListWithoutEmptyValuesBuilder();
+        options.add(getSilentCompilerOption());
+        options.add(getStrictImportsCompilerOption());
+        options.add(getCompressCompilerOption());
+        options.add(getDependsCompilerOption());
+        options.add(getIeCompatabilityCompilerOption());
+        options.add(getJavaScriptEnabledCompilerOption());
+        options.add(getIncludePathsCompilerOption());
+        options.add(getLineNumbersCompilerOption());
+        options.add(getRootPathCompilerOption());
+        options.add(getRelativeUrlsCompilerOption());
+        options.add(getStrictMathCompilerOption());
+        options.add(getStrictUnitsCompilerOption());
+        return options.create();
     }
 
     /**