Skip to content

Commit d4dbe17

Browse files
committed
Improvements from comments in PR ethereum#2411
1 parent 5f95ffe commit d4dbe17

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

ens/main.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ def _set_resolver(
522522
def _get_resolver(
523523
self,
524524
normal_name: str,
525-
func: str = 'addr'
525+
func_name: str = 'addr'
526526
) -> Tuple[Optional['Contract'], str]:
527527
current_name = normal_name
528528

@@ -537,7 +537,7 @@ def _get_resolver(
537537
resolver_addr = self.ens.caller.resolver(normal_name_to_hash(current_name))
538538
if not is_none_or_zero_address(resolver_addr):
539539
# if resolver found, return it
540-
return self._type_aware_resolver(resolver_addr, func), current_name
540+
return self._type_aware_resolver(resolver_addr, func_name), current_name
541541

542542
# set current_name to parent and try again
543543
current_name = self.parent(current_name)
@@ -548,6 +548,8 @@ def _decode_ensip10_resolve_data(
548548
func = extended_resolver.get_function_by_name(fn_name)
549549
output_types = get_abi_output_types(func.abi)
550550
decoded = self.w3.codec.decode_abi(output_types, contract_call_result)
551+
552+
# if decoding a single value, return that value - else, return the tuple
551553
return decoded[0] if len(decoded) == 1 else decoded
552554

553555
def _setup_reverse(

tests/ens/test_get_text.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,9 @@ def test_get_text(ens, key, expected):
6666
ens.set_text('tester.eth', key, expected)
6767
assert ens.get_text('tester.eth', key) == expected
6868

69+
# teardown
70+
ens.setup_address('tester.eth', None)
71+
6972

7073
def test_get_text_resolver_not_found(ens):
7174
with pytest.raises(ResolverNotFound):

0 commit comments

Comments
 (0)