Skip to content

Commit 1437108

Browse files
committed
Changes from comments on PR ethereum#3030 & minor cleanup
1 parent e7cdbc3 commit 1437108

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

ens/async_ens.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ def from_web3(cls, w3: "AsyncWeb3", addr: ChecksumAddress = None) -> "AsyncENS":
140140
async def address(
141141
self,
142142
name: str,
143-
coin_type: int = None,
143+
coin_type: Optional[int] = None,
144144
) -> Optional[ChecksumAddress]:
145145
"""
146146
Look up the Ethereum address that `name` currently points to.
@@ -170,7 +170,7 @@ async def setup_address(
170170
address: Union[Address, ChecksumAddress, HexAddress] = cast(
171171
ChecksumAddress, default
172172
),
173-
coin_type: int = None,
173+
coin_type: Optional[int] = None,
174174
transact: Optional["TxParams"] = None,
175175
) -> Optional[HexBytes]:
176176
"""
@@ -186,6 +186,7 @@ async def setup_address(
186186
:param str address: name will point to this address, in checksum format.
187187
If ``None``, erase the record. If not specified, name will point
188188
to the owner's address.
189+
:param int coin_type: if provided, set up the address for this coin type
189190
:param dict transact: the transaction configuration, like in
190191
:meth:`~web3.eth.Eth.send_transaction`
191192
:raises InvalidName: if ``name`` has invalid syntax

ens/contract_data.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
This contract data is taken form the actual ENS contracts deployed on mainnet.
66
The information was taken from etherscan.io and may need to be updated as the ENS
77
contracts are updated.
8+
9+
https://etherscan.io/accounts/label/ens
810
"""
911

1012
# ENS Default Registrar

ens/ens.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ def setup_address(
187187
:param str address: name will point to this address, in checksum format.
188188
If ``None``, erase the record. If not specified, name will point
189189
to the owner's address.
190-
:param int coin_type: if provided, set the address for this coin type
190+
:param int coin_type: if provided, set up the address for this coin type
191191
:param dict transact: the transaction configuration, like in
192192
:meth:`~web3.eth.Eth.send_transaction`
193193
:raises InvalidName: if ``name`` has invalid syntax

0 commit comments

Comments
 (0)