Skip to content

Commit bc49cfe

Browse files
authored
Merge pull request #10 from facebook/master
pulling changes from upstream
2 parents 20be1b6 + 4c7c3c5 commit bc49cfe

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

73 files changed

+2499
-2308
lines changed
File renamed without changes.

.github/ISSUE_TEMPLATE.md

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,13 @@
66

77
(write your answer here)
88

9+
910
<!--
1011
If you answered "Yes":
11-
12+
1213
Please note that your issue will be fixed much faster if you spend about
1314
half an hour preparing it, including the exact reproduction steps and a demo.
14-
15+
1516
If you're in a hurry or don't feel confident, it's fine to report bugs with
1617
less details, but this makes it less likely they'll get fixed soon.
1718
@@ -37,14 +38,14 @@
3738
Then you need to decide which package manager you prefer to use.
3839
We support both npm (https://npmjs.com) and yarn (http://yarnpkg.com/).
3940
However, **they can't be used together in one project** so you need to pick one.
40-
41+
4142
If you decided to use npm, run this in your project directory:
4243
4344
npm install -g npm@latest
4445
npm install
4546
4647
This should fix your project.
47-
48+
4849
If you decided to use yarn, update it first (https://yarnpkg.com/en/docs/install).
4950
Then run in your project directory:
5051
@@ -62,19 +63,20 @@
6263

6364
(Write your answer here.)
6465

66+
6567
### Which terms did you search for in User Guide?
6668

6769
<!--
6870
There are a few common documented problems, such as watcher not detecting changes, or build failing.
6971
They are described in the Troubleshooting section of the User Guide:
7072
71-
https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#troubleshooting
73+
https://facebook.github.io/create-react-app/docs/troubleshooting
7274
7375
Please scan these few sections for common problems.
7476
Additionally, you can search the User Guide itself for something you're having issues with:
75-
76-
https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md
77-
77+
78+
https://facebook.github.io/create-react-app/
79+
7880
If you didn't find the solution, please share which words you searched for.
7981
This helps us improve documentation for future readers who might encounter the same problem.
8082
-->
@@ -98,6 +100,7 @@
98100

99101
(paste the output of the command here)
100102

103+
101104
### Steps to Reproduce
102105

103106
<!--
@@ -154,13 +157,14 @@
154157

155158
(Paste the link to an example project and exact instructions to reproduce the issue.)
156159

160+
157161
<!--
158162
What happens if you skip this step?
159-
163+
160164
We will try to help you, but in many cases it is impossible because crucial
161165
information is missing. In that case we'll tag an issue as having a low priority,
162166
and eventually close it if there is no clear direction.
163-
167+
164168
We still appreciate the report though, as eventually somebody else might
165169
create a reproducible example for it.
166170

.github/lock.yml

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,11 @@
11
# Configuration for lock-threads - https://github.com/dessant/lock-threads
22

33
# Number of days of inactivity before a closed issue or pull request is locked
4-
daysUntilLock: 7
5-
setLockReason: false
4+
daysUntilLock: 5
65

7-
issues:
8-
# Comment to post when locking a stale Issue.
9-
lockComment: >
10-
The conversation for this issue has been locked because the issue is
11-
closed. If you would like to contribute please open a new issue.
6+
# Issues and pull requests with these labels will not be locked. Set to `[]` to disable
7+
exemptLabels: []
128

13-
pulls:
14-
# Comment to post when locking a stale Pull Request.
15-
lockComment: >
16-
The conversation for this pull request has been locked because the pull
17-
request is closed. If you would like to contribute please open a new pull
18-
request.
9+
# Do not comment when locking
10+
setLockReason: false
11+
lockComment: false

.github/stale.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
# Configuration for probot-stale - https://github.com/probot/stale
22

33
# Number of days of inactivity before an Issue or Pull Request becomes stale
4-
daysUntilStale: 60
4+
daysUntilStale: 30
55

66
# Number of days of inactivity before a stale Issue or Pull Request is closed.
77
# Set to false to disable. If disabled, issues still need to be closed manually, but will remain marked as stale.
8-
daysUntilClose: 7
8+
daysUntilClose: 5
99

1010
# Issues or Pull Requests with these labels will never be considered stale. Set to `[]` to disable
1111
exemptLabels:
@@ -28,23 +28,22 @@ issues:
2828
# Comment to post when marking Issues as stale.
2929
markComment: >
3030
This issue has been automatically marked as stale because it has not had any
31-
recent activity. It will be closed in 7 days if no further activity occurs.
31+
recent activity. It will be closed in 5 days if no further activity occurs.
3232
3333
# Comment to post when closing a stale Issue.
3434
closeComment: >
3535
This issue has been automatically closed because it has not had any recent
36-
activity. The conversation will be locked in 7 days unless the issue is
37-
reopened.
36+
activity. If you have a question or comment, please open a new issue.
3837
3938
pulls:
4039
# Comment to post when marking Pull Request as stale.
4140
markComment: >
4241
This pull request has been automatically marked as stale because it has not
43-
had any recent activity. It will be closed in 7 days if no further activity
42+
had any recent activity. It will be closed in 5 days if no further activity
4443
occurs.
4544
4645
# Comment to post when closing a stale Pull Request.
4746
closeComment: >
4847
This pull request has been automatically closed because it has not had any
49-
recent activity. The conversation will be locked in 7 days unless the pull
50-
request is reopened. Thank you for your contribution.
48+
recent activity. If you have a question or comment, please open a new
49+
issue. Thank you for your contribution!

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ language: node_js
44
node_js:
55
- 8
66
- 10
7+
- node
78
cache:
89
yarn: true
910
directories:

CHANGELOG.md

Lines changed: 139 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,142 @@
1+
## 2.1.2 (December 23, 2018)
2+
3+
v2.1.2 is a maintenance release including various bug fixes.
4+
5+
#### :rocket: New Feature
6+
7+
- `babel-preset-react-app`
8+
- [#5487](https://github.com/facebook/create-react-app/pull/5487) Add `allowESModules` option to `babel-preset-react-app` ([@Pajn](https://github.com/Pajn))
9+
10+
#### :bug: Bug Fix
11+
12+
- `create-react-app`
13+
- [#5905](https://github.com/facebook/create-react-app/pull/5905) Disable copy to clipboard in `create-react-app --info` ([@heyimalex](https://github.com/heyimalex))
14+
- [#5685](https://github.com/facebook/create-react-app/pull/5685) Update envinfo to `5.11.1` ([@tabrindle](https://github.com/tabrindle))
15+
- `babel-preset-react-app`
16+
- [#5783](https://github.com/facebook/create-react-app/pull/5783) Fix TypeScript decorator support ([@ianschmitz](https://github.com/ianschmitz))
17+
- `babel-plugin-named-asset-import`
18+
- [#5573](https://github.com/facebook/create-react-app/pull/5573) Fix named-asset-import plugin to work with export-as syntax ([@NShahri](https://github.com/NShahri))
19+
- `react-app-polyfill`
20+
- [#5789](https://github.com/facebook/create-react-app/pull/5789) Don't polyfill fetch for Node ([@gshilin](https://github.com/gshilin))
21+
- `react-scripts`
22+
- [#5721](https://github.com/facebook/create-react-app/pull/5721) Version bump `postcss-preset-env` to latest ([@BPScott](https://github.com/BPScott))
23+
- [#5701](https://github.com/facebook/create-react-app/pull/5701) Fix `tsconfig.json` lib suggested value ([@ianschmitz](https://github.com/ianschmitz))
24+
25+
#### :nail_care: Enhancement
26+
27+
- `react-scripts`
28+
- [#5698](https://github.com/facebook/create-react-app/pull/5698) Add support for `setupTests.ts` ([@ianschmitz](https://github.com/ianschmitz))
29+
30+
#### :memo: Documentation
31+
32+
- Other
33+
- [#6009](https://github.com/facebook/create-react-app/pull/6009) Correct markdown to avoid comment. ([@souzasmatheus](https://github.com/souzasmatheus))
34+
- [#6015](https://github.com/facebook/create-react-app/pull/6015) Add example command to create typed project. ([@mbelsky](https://github.com/mbelsky))
35+
- [#6000](https://github.com/facebook/create-react-app/pull/6000) Make links to docs consistent in README. ([@iansu](https://github.com/iansu))
36+
- [#5900](https://github.com/facebook/create-react-app/pull/5900) Add production build section to docs. ([@ianschmitz](https://github.com/ianschmitz))
37+
- [#5985](https://github.com/facebook/create-react-app/pull/5985) Use https for linked images to fix mixed content warnings. ([@iansu](https://github.com/iansu))
38+
- [#5919](https://github.com/facebook/create-react-app/pull/5919) Docs: update localStorage mock in “Running Tests”. ([@phacks](https://github.com/phacks))
39+
- [#5917](https://github.com/facebook/create-react-app/pull/5917) Add SASS_PATH instructions to Sass stylesheet docs. ([@jayantbh](https://github.com/jayantbh))
40+
- [#5823](https://github.com/facebook/create-react-app/pull/5823) Add default values to `file_ext` note. ([@alaycock](https://github.com/alaycock))
41+
- [#5907](https://github.com/facebook/create-react-app/pull/5907) Update README.md with updated link about PWAs. ([@wuweiweiwu](https://github.com/wuweiweiwu))
42+
- [#5858](https://github.com/facebook/create-react-app/pull/5858) Some Grammar fixes. ([@nikhilknoldus](https://github.com/nikhilknoldus))
43+
- [#5883](https://github.com/facebook/create-react-app/pull/5883) Fix link to page about running tests. ([@wsmoak](https://github.com/wsmoak))
44+
- [#5849](https://github.com/facebook/create-react-app/pull/5849) React native repository updated in `README.md`. ([@pavinthan](https://github.com/pavinthan))
45+
- [#5806](https://github.com/facebook/create-react-app/pull/5806) Rename 'getting started' link to 'docs'. ([@kulek1](https://github.com/kulek1))
46+
- [#5788](https://github.com/facebook/create-react-app/pull/5788) docs: Simplify installing Storybook with `npx` ([@sagirk](https://github.com/sagirk))
47+
- [#5779](https://github.com/facebook/create-react-app/pull/5779) docs: Change story book command to `sb init` ([@andys8](https://github.com/andys8))
48+
- [#5759](https://github.com/facebook/create-react-app/pull/5759) Add PR welcoming badge ([@open-source-explorer](https://github.com/open-source-explorer))
49+
- [#5730](https://github.com/facebook/create-react-app/pull/5730) Suggest Encore when not building a SPA with Symfony ([@dunglas](https://github.com/dunglas))
50+
- [#5710](https://github.com/facebook/create-react-app/pull/5710) Updated the link to firebase hosting ([@githubsaturn](https://github.com/githubsaturn))
51+
- [#5704](https://github.com/facebook/create-react-app/pull/5704) Fixed link to manifest.json file ([@m4jing](https://github.com/m4jing))
52+
- [#5670](https://github.com/facebook/create-react-app/pull/5670) Fix public folder documentation link ([@makovkastar](https://github.com/makovkastar))
53+
- `eslint-config-react-app`
54+
- [#5990](https://github.com/facebook/create-react-app/pull/5990) Updated docs for `.eslintrc` ([@ManoelLobo](https://github.com/ManoelLobo))
55+
- `babel-preset-react-app`, `create-react-app`, `eslint-config-react-app`, `react-dev-utils`, `react-scripts`
56+
- [#5912](https://github.com/facebook/create-react-app/pull/5912) Update links to docs in all package README files ([@iansu](https://github.com/iansu))
57+
- `react-scripts`
58+
- [#5974](https://github.com/facebook/create-react-app/pull/5974) Improve advice in `verifyPackageTree.js` ([@sjalgeo](https://github.com/sjalgeo))
59+
- [#5954](https://github.com/facebook/create-react-app/pull/5954) Add pre-eject message about new features in v2 ([@iansu](https://github.com/iansu))
60+
- [#5808](https://github.com/facebook/create-react-app/pull/5808) Add placeholders to template README for bit.ly links ([@iansu](https://github.com/iansu))
61+
- `react-app-polyfill`
62+
- [#5814](https://github.com/facebook/create-react-app/pull/5814) Note that extra polyfills must be included manually ([@ajwann](https://github.com/ajwann))
63+
- `babel-preset-react-app`, `eslint-config-react-app`, `react-error-overlay`, `react-scripts`
64+
- [#5727](https://github.com/facebook/create-react-app/pull/5727) Fix typo ([@noelyoo](https://github.com/noelyoo))
65+
66+
#### :house: Internal
67+
68+
- `react-scripts`
69+
- [#5978](https://github.com/facebook/create-react-app/pull/5978) Add `webp` support for TypeScript. ([@dugagjin](https://github.com/dugagjin))
70+
- [#5959](https://github.com/facebook/create-react-app/pull/5959) Suggest a different default for speed reasons. ([@Timer](https://github.com/Timer))
71+
- [#5839](https://github.com/facebook/create-react-app/pull/5839) Run prettier on HTML files. ([@sibiraj-s](https://github.com/sibiraj-s))
72+
- [#5722](https://github.com/facebook/create-react-app/pull/5722) Merge webpack configuration. ([@Timer](https://github.com/Timer))
73+
- [#5694](https://github.com/facebook/create-react-app/pull/5694) Add permissive TS lib defaults. ([@Timer](https://github.com/Timer))
74+
- Other
75+
- [#5988](https://github.com/facebook/create-react-app/pull/5988) Added extension to `.eslintrc` ([@ManoelLobo](https://github.com/ManoelLobo))
76+
- [#5546](https://github.com/facebook/create-react-app/pull/5546) Add the latest stable node version. ([@noelyoo](https://github.com/noelyoo))
77+
- `react-dev-utils`
78+
- [#5927](https://github.com/facebook/create-react-app/pull/5927) Correct some comments. ([@mjackson](https://github.com/mjackson))
79+
- [#5879](https://github.com/facebook/create-react-app/pull/5879) fix: make typescriptformatter support 0.5 of fork checker. ([@SimenB](https://github.com/SimenB))
80+
- `react-error-overlay`
81+
- [#5451](https://github.com/facebook/create-react-app/pull/5451) fix: add `sideEffects: false` to react-error-overlay. ([@SimenB](https://github.com/SimenB))
82+
- `babel-preset-react-app`
83+
- [#5487](https://github.com/facebook/create-react-app/pull/5487) Add allowESModules option to babel-preset-react-app. ([@Pajn](https://github.com/Pajn))
84+
- `create-react-app`
85+
- [#4605](https://github.com/facebook/create-react-app/pull/4605) ignore intellij module files when generating an app. ([@denofevil](https://github.com/denofevil))
86+
87+
#### Committers: 36
88+
89+
- \<Explorer /\> ([open-source-explorer](https://github.com/open-source-explorer))
90+
- Adam Laycock ([alaycock](https://github.com/alaycock))
91+
- Adam Wanninger ([ajwann](https://github.com/ajwann))
92+
- Alex Guerra ([heyimalex](https://github.com/heyimalex))
93+
- Andy ([andys8](https://github.com/andys8))
94+
- Ben Scott ([BPScott](https://github.com/BPScott))
95+
- Dennis Ushakov ([denofevil](https://github.com/denofevil))
96+
- Dugagjin Lashi ([dugagjin](https://github.com/dugagjin))
97+
- Gregory Shilin ([gshilin](https://github.com/gshilin))
98+
- Ian Schmitz ([ianschmitz](https://github.com/ianschmitz))
99+
- Ian Sutherland ([iansu](https://github.com/iansu))
100+
- Jayant Bhawal ([jayantbh](https://github.com/jayantbh))
101+
- Jing Ma ([m4jing](https://github.com/m4jing))
102+
- Joe Haddad ([Timer](https://github.com/Timer))
103+
- Kasra Bigdeli ([githubsaturn](https://github.com/githubsaturn))
104+
- Kévin Dunglas ([dunglas](https://github.com/dunglas))
105+
- Manoel ([ManoelLobo](https://github.com/ManoelLobo))
106+
- Matheus Souza ([souzasmatheus](https://github.com/souzasmatheus))
107+
- Max Belsky ([mbelsky](https://github.com/mbelsky))
108+
- Michael Jackson ([mjackson](https://github.com/mjackson))
109+
- Nicolas Goutay ([phacks](https://github.com/phacks))
110+
- Nikhil ([nikhilknoldus](https://github.com/nikhilknoldus))
111+
- Nima Shahri ([NShahri](https://github.com/NShahri))
112+
- Noel Yoo ([noelyoo](https://github.com/noelyoo))
113+
- Oleksandr Melnykov ([makovkastar](https://github.com/makovkastar))
114+
- Pavinthan ([pavinthan](https://github.com/pavinthan))
115+
- Rasmus Eneman ([Pajn](https://github.com/Pajn))
116+
- Sagir Khan ([sagirk](https://github.com/sagirk))
117+
- Sibiraj ([sibiraj-s](https://github.com/sibiraj-s))
118+
- Simen Bekkhus ([SimenB](https://github.com/SimenB))
119+
- Stephen Algeo ([sjalgeo](https://github.com/sjalgeo))
120+
- Trevor Brindle ([tabrindle](https://github.com/tabrindle))
121+
- Wei-Wei Wu ([wuweiweiwu](https://github.com/wuweiweiwu))
122+
- Wendy Smoak ([wsmoak](https://github.com/wsmoak))
123+
- [kulek1](https://github.com/kulek1)
124+
- swyx ([sw-yx](https://github.com/sw-yx))
125+
126+
### Migrating from 2.1.1 to 2.1.2
127+
128+
Inside any created project that has not been ejected, run:
129+
130+
```bash
131+
npm install --save --save-exact [email protected]
132+
```
133+
134+
or
135+
136+
```
137+
yarn add --exact [email protected]
138+
```
139+
1140
## 2.1.1 (October 31, 2018)
2141

3142
Happy Halloween 🎃 👻! This spooky release brings a treat: decorator support in TypeScript files!

CONTRIBUTING.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,7 @@ By default git would use `CRLF` line endings which would cause the scripts to fa
142142
9. Wait for a long time, and it will get published. Don’t worry that it’s stuck. In the end the publish script will prompt for versions before publishing the packages.
143143
10. After publishing, create a GitHub Release with the same text as the changelog entry. See previous Releases for inspiration.
144144

145-
Make sure to test the released version! If you want to be extra careful, you can publish a prerelease by running `npm run publish -- --npm-tag=next` instead of `npm run publish`.
146-
147-
Optionally, you can cut a prerelease instead by running `npm run publish -- --canary=next --exact --cd-version patch --npm-tag=next`.
145+
Make sure to test the released version! If you want to be extra careful, you can publish a prerelease by running `npm run publish -- --canary=next --exact --cd-version patch --npm-tag=next` instead of `npm run publish`.
148146

149147
---
150148

0 commit comments

Comments
 (0)