Skip to content

Commit e03ea87

Browse files
author
fpapado
committed
TS BUG: need declaration: false to build correctly
If we set declaration: true, then typescript (specifically rpt2, Rollup's TS plugin) fails with a cryptic path error. This is filed under microsoft/TypeScript#25047. Curiously, this does not happen on master, and I have vaguely traced it back to unionize and the fact that it does fancy type exports, which we partially re-export here. We would have to manually emit a declaration file, which is not hard tbh, but a bit annoying. Even funnier, webpack has no issue building in storybook, but that might be because it does not emit declarations anyway. Steps: - Get declaration file from master, add to repository, and copy to dist/ upon build; - See if massaging our exports fixes it; - Wait for TS :/
1 parent e83163e commit e03ea87

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"compilerOptions": {
33
"module": "es2015",
44
"target": "es5",
5-
"declaration": true,
5+
"declaration": false,
66
"sourceMap": true,
77
"jsx": "react",
88
"allowJs": false,

0 commit comments

Comments
 (0)