Skip to content

Conversation

@prabhupant
Copy link
Contributor

Fixes #5481

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

adds the sessions factory in create sessions dredd hook

Changes proposed in this pull request:

  • use sessions factory in place of event factory

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #5482 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5482   +/-   ##
============================================
  Coverage        62.95%   62.95%           
============================================
  Files              263      263           
  Lines            12674    12674           
============================================
  Hits              7979     7979           
  Misses            4695     4695

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d2b8d...8cebf20. Read the comment docs.

@prabhupant
Copy link
Contributor Author

@iamareebjamal @srv-twry please review :)

@dr0pdb dr0pdb merged commit 2c59259 into fossasia:development Dec 21, 2018
prabhupant added a commit to prabhupant/open-event-server that referenced this pull request Dec 24, 2018
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

corrections in sessions test

3 participants